Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Side by Side Diff: src/ia32/codegen-ia32.cc

Issue 3010060: Fix bug in binary operations code. When loading a 32-bit integer as a... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1348 matching lines...) Expand 10 before | Expand all | Expand 10 after
1359 __ AllocateHeapNumber(left_, right_, no_reg, &after_alloc_failure2); 1359 __ AllocateHeapNumber(left_, right_, no_reg, &after_alloc_failure2);
1360 __ bind(&allocation_ok); 1360 __ bind(&allocation_ok);
1361 if (CpuFeatures::IsSupported(SSE2) && op_ != Token::SHR) { 1361 if (CpuFeatures::IsSupported(SSE2) && op_ != Token::SHR) {
1362 CpuFeatures::Scope use_sse2(SSE2); 1362 CpuFeatures::Scope use_sse2(SSE2);
1363 ASSERT(Token::IsBitOp(op_)); 1363 ASSERT(Token::IsBitOp(op_));
1364 // Signed conversion. 1364 // Signed conversion.
1365 __ cvtsi2sd(xmm0, Operand(dst_)); 1365 __ cvtsi2sd(xmm0, Operand(dst_));
1366 __ movdbl(FieldOperand(left_, HeapNumber::kValueOffset), xmm0); 1366 __ movdbl(FieldOperand(left_, HeapNumber::kValueOffset), xmm0);
1367 } else { 1367 } else {
1368 if (op_ == Token::SHR) { 1368 if (op_ == Token::SHR) {
1369 __ push(Immediate(0)); // High word of unsigned value.
1369 __ push(dst_); 1370 __ push(dst_);
1370 __ push(Immediate(0)); // High word of unsigned value.
1371 __ fild_d(Operand(esp, 0)); 1371 __ fild_d(Operand(esp, 0));
1372 __ Drop(2); 1372 __ Drop(2);
1373 } else { 1373 } else {
1374 ASSERT(Token::IsBitOp(op_)); 1374 ASSERT(Token::IsBitOp(op_));
1375 __ push(dst_); 1375 __ push(dst_);
1376 __ fild_s(Operand(esp, 0)); // Signed conversion. 1376 __ fild_s(Operand(esp, 0)); // Signed conversion.
1377 __ pop(dst_); 1377 __ pop(dst_);
1378 } 1378 }
1379 __ fstp_d(FieldOperand(left_, HeapNumber::kValueOffset)); 1379 __ fstp_d(FieldOperand(left_, HeapNumber::kValueOffset));
1380 } 1380 }
(...skipping 12880 matching lines...) Expand 10 before | Expand all | Expand 10 after
14261 masm.GetCode(&desc); 14261 masm.GetCode(&desc);
14262 // Call the function from C++. 14262 // Call the function from C++.
14263 return FUNCTION_CAST<MemCopyFunction>(buffer); 14263 return FUNCTION_CAST<MemCopyFunction>(buffer);
14264 } 14264 }
14265 14265
14266 #undef __ 14266 #undef __
14267 14267
14268 } } // namespace v8::internal 14268 } } // namespace v8::internal
14269 14269
14270 #endif // V8_TARGET_ARCH_IA32 14270 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698