Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 3007025: Merge 54188 - [Mac] First pass at final sizing of toolbar items.... (Closed)

Created:
10 years, 4 months ago by Peter Kasting
Modified:
9 years, 7 months ago
CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 54188 - [Mac] First pass at final sizing of toolbar items. Toolbar.xib changes: - buttons from 31x27 to 29x29 so that the visual is 27x27. - shift things left to take up opened space. - omnibox to 29 pixels tall. - wrench also to 29x29. - all of that raised a single pixel to recenter. - swap positions of home and reload. Modify home-button-adjustment code to reflect rearranged home/reload positions. Increase Omnibox font size by one point to match increased field height (and Windows Omnibox). Revise various font clients to recognize this. Shift Omnibox baseline and other measurements to account for increased height. Shift globe/search icon in by one pixel so icons on both sides of Omnibox are 4px from border. Matching shift in popup. Fix EV-bubble to use appropriate green for text, rather than black. Push out bubble to have a single-pixel space WRT Omnibox border. Tighten corners to tuck into Omnibox corners. Handle different lhs padding versus location icon (image should end up in same spot, even though the bubble draws outside the image). BUG=50575 TEST=none Review URL: http://codereview.chromium.org/3046029 TBR=shess@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -978 lines) Patch
M chrome/app/nibs/Toolbar.xib View 35 chunks +51 lines, -945 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/location_bar/bubble_decoration.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/cocoa/location_bar/bubble_decoration.mm View 7 chunks +52 lines, -14 lines 0 comments Download
M chrome/browser/cocoa/location_bar/keyword_hint_decoration.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/toolbar_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/cocoa/toolbar_controller_unittest.mm View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Peter Kasting
10 years, 4 months ago (2010-08-03 01:53:26 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698