Issue 3007020: Add a hardware_class attribute (for HWID, HWQual ID) to the Omaha request.

Issue 3007020: Add a hardware_class attribute (for HWID, HWQual ID) to the Omaha request. (Closed)

Created:
10 years, 4 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler, adlr

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

Add a hardware_class attribute (for HWID, HWQual ID) to the Omaha request. BUG=1600 TEST=unit tests, gmerge and looked at request logs

Patch Set 2 : address review comments #

Patch Set 3 : fix typo #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -8 lines)			Patch
M	action.h	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	action_pipe.h	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	omaha_request_action.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	omaha_request_action_unittest.cc	View	1	5 chunks	+7 lines, -0 lines	0 comments	Download
M	omaha_request_params.h	View	1 2	4 chunks	+7 lines, -0 lines	0 comments	Download
M	omaha_request_params.cc	View	1	4 chunks	+14 lines, -0 lines	0 comments	Download
M	omaha_request_params_unittest.cc	View	1	3 chunks	+18 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

rspangler: could you please review the HWID file path specific in omaha_request_params.cc? thanks.

10 years, 4 months ago (2010-07-29 23:16:49 UTC) #1

adlr

LGTM w/ comments http://codereview.chromium.org/3007020/diff/1/2 File action.h (right): http://codereview.chromium.org/3007020/diff/1/2#newcode129 action.h:129: LOG(INFO) << "Action destructed"; i think ...

10 years, 4 months ago (2010-07-29 23:36:04 UTC) #2

petkov

10 years, 4 months ago (2010-07-29 23:52:15 UTC) #3

Addressed comments and confirmed new path with Vadim. Pushing...

http://codereview.chromium.org/3007020/diff/1/2
File action.h (right):

http://codereview.chromium.org/3007020/diff/1/2#newcode129
action.h:129: LOG(INFO) << "Action destructed";
On 2010/07/29 23:36:04, adlr wrote:
> i think we could even get rid of this. it's been reliable for ages now and the
> log messages freak people out.

Done.

http://codereview.chromium.org/3007020/diff/1/3
File action_pipe.h (right):

http://codereview.chromium.org/3007020/diff/1/3#newcode45
action_pipe.h:45: LOG(INFO) << "ActionPipe destructed";
On 2010/07/29 23:36:04, adlr wrote:
> same

Done.

http://codereview.chromium.org/3007020/diff/1/5
File omaha_request_action_unittest.cc (right):

http://codereview.chromium.org/3007020/diff/1/5#newcode588
omaha_request_action_unittest.cc:588: "hardware-class",
On 2010/07/29 23:36:04, adlr wrote:
> you might just want to use a semi-realistic hardware class like:
> 
> OEM MODEL REVISION 9471
> 
> or
> 
> OEM MODEL 09235 7471
> 
> not really a big deal tho...

Done.

http://codereview.chromium.org/3007020/diff/1/6
File omaha_request_params.cc (right):

http://codereview.chromium.org/3007020/diff/1/6#newcode31
omaha_request_params.cc:31: static const char kHWIDPath[] =
"/sys/bus/platform/devices/chromeos_acpi/HWID";
On 2010/07/29 23:36:04, adlr wrote:
> iirc, it's
> 
> /sys/devices/platform/chromeos_acpi/HWID

Based on discussion with Vadim, they both refer to the same file. Switched to
shorter path.

Expand Messages | Collapse Messages