Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2247)

Unified Diff: omaha_request_params_unittest.cc

Issue 3007020: Add a hardware_class attribute (for HWID, HWQual ID) to the Omaha request. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/update_engine.git
Patch Set: fix typo Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « omaha_request_params.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: omaha_request_params_unittest.cc
diff --git a/omaha_request_params_unittest.cc b/omaha_request_params_unittest.cc
index 19898f4e34e5cf98b8b905dc9b61725f04038977..0150a00292d395ceb9aa8039baca24cdb6eb9f14 100644
--- a/omaha_request_params_unittest.cc
+++ b/omaha_request_params_unittest.cc
@@ -3,8 +3,11 @@
// found in the LICENSE file.
#include <stdio.h>
+
#include <string>
-#include <gtest/gtest.h>
+
+#include "base/file_util.h"
+#include "gtest/gtest.h"
#include "update_engine/install_plan.h"
#include "update_engine/omaha_request_params.h"
#include "update_engine/test_utils.h"
@@ -85,6 +88,7 @@ TEST_F(OmahaRequestDeviceParamsTest, SimpleTest) {
EXPECT_EQ("{87efface-864d-49a5-9bb3-4b050a7c227a}", out.app_id);
EXPECT_EQ("0.2.2.3", out.app_version);
EXPECT_EQ("en-US", out.app_lang);
+ EXPECT_EQ("", out.hardware_class);
EXPECT_TRUE(out.delta_okay);
EXPECT_EQ("footrack", out.app_track);
EXPECT_EQ("http://www.google.com", out.update_url);
@@ -210,4 +214,17 @@ TEST_F(OmahaRequestDeviceParamsTest, NoDeltasTest) {
EXPECT_FALSE(out.delta_okay);
}
+TEST_F(OmahaRequestDeviceParamsTest, HardwareClassTest) {
+ string test_class = " \t sample hardware class \n ";
+ FilePath hwid_path(kTestDir + "/sys/devices/platform/chromeos_acpi/HWID");
+ ASSERT_TRUE(file_util::CreateDirectory(hwid_path.DirName()));
+ ASSERT_EQ(test_class.size(),
+ file_util::WriteFile(hwid_path,
+ test_class.data(),
+ test_class.size()));
+ OmahaRequestParams out;
+ EXPECT_TRUE(DoTest(&out, "", ""));
+ EXPECT_EQ("sample hardware class", out.hardware_class);
+}
+
} // namespace chromeos_update_engine
« no previous file with comments | « omaha_request_params.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698