Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: pylib/gyp/generator/make.py

Issue 300016: Fix generators to make sure changes to rule inputs trigger correct rebuilds.... (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: add same_target.gyp Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/rules-rebuild/gyptest-all.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/make.py
===================================================================
--- pylib/gyp/generator/make.py (revision 762)
+++ pylib/gyp/generator/make.py (working copy)
@@ -46,10 +46,10 @@
'LIB_DIR': '$(obj).$(TOOLSET)',
'RULE_INPUT_ROOT': '%(INPUT_ROOT)s', # This gets expanded by Python.
'RULE_INPUT_PATH': '$(abspath $<)',
+ 'RULE_INPUT_EXT': '$(suffix $<)',
+ 'RULE_INPUT_NAME': '$(notdir $<)',
- # These appear unused -- ???
- 'RULE_INPUT_EXT': 'XXXEXT$(suffix $^)',
- 'RULE_INPUT_NAME': 'XXXNAME$(notdir $(basename $^)0',
+ # This appears unused --- ?
'CONFIGURATION_NAME': '$(BUILDTYPE)',
}
« no previous file with comments | « no previous file | test/rules-rebuild/gyptest-all.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698