Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2993473002: Clean up ObjC BUILD file

Created:
3 years, 4 months ago by magjed_webrtc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sakal
Target Ref:
refs/heads/HEAD
Project:
webrtc
Visibility:
Public.

Description

Clean up ObjC BUILD file This CL mainly moves the video capture related files from the PeerConnection folder to a new VideoCapture folder. It also removes some unnecessary dependencies from some targets in webrtc/sdk/BUILD.gn. BUG=None

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -665 lines) Patch
M webrtc/examples/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/sdk/BUILD.gn View 7 chunks +16 lines, -31 lines 1 comment Download
D webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCCameraVideoCapturer.m View 1 chunk +0 lines, -448 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCFileVideoCapturer.h View 1 chunk +0 lines, -25 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCFileVideoCapturer.m View 1 chunk +0 lines, -163 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/VideoCapture/RTCCameraVideoCapturer.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/VideoCapture/RTCFileVideoCapturer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/VideoCapture/RTCFileVideoCapturer.m View 0 chunks +-1 lines, --1 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (14 generated)
magjed_webrtc
Please take a look.
3 years, 4 months ago (2017-07-31 15:17:15 UTC) #15
Taylor Brandstetter
lgtm
3 years, 4 months ago (2017-08-01 00:31:30 UTC) #16
daniela-webrtc
3 years, 4 months ago (2017-08-01 08:35:08 UTC) #17
lgtm

https://codereview.webrtc.org/2993473002/diff/40001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (left):

https://codereview.webrtc.org/2993473002/diff/40001/webrtc/sdk/BUILD.gn#oldco...
webrtc/sdk/BUILD.gn:322: ":objc_video",
Is this removed intentionally?

Powered by Google App Engine
This is Rietveld 408576698