Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2987143003: Remove RTCAVFoundationVideoSource

Created:
3 years, 4 months ago by magjed_webrtc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sakal
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove RTCAVFoundationVideoSource RTCAVFoundationVideoSource has been deprecated and replaced with a generic RTCVideoSource combined with an RTCVideoCapturer implementation, e.g. RTCCameraVideoCapturer. BUG=webrtc:7177

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1404 lines) Patch
M tools_webrtc/ios/SDK/PodTest/PodTest/ViewController.m View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/ARDAppClient.m View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/examples/objc/AppRTCMobile/ios/ARDVideoCallViewController.m View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/BUILD.gn View 6 chunks +0 lines, -11 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCAVFoundationVideoSource.mm View 1 chunk +0 lines, -62 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCAVFoundationVideoSource+Private.h View 1 chunk +0 lines, -27 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm View 2 chunks +0 lines, -10 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.mm View 1 chunk +0 lines, -518 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/Video/avfoundationformatmapper.h View 1 chunk +0 lines, -29 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/Video/avfoundationformatmapper.mm View 1 chunk +0 lines, -135 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/Video/avfoundationvideocapturer.h View 1 chunk +0 lines, -72 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/Video/avfoundationvideocapturer.mm View 1 chunk +0 lines, -179 lines 0 comments Download
D webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAVFoundationVideoSource.h View 1 chunk +0 lines, -55 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCCameraPreviewView.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/WebRTC.h View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/sdk/objc/Framework/UnitTests/avformatmappertests.mm View 1 chunk +0 lines, -246 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (12 generated)
magjed_webrtc
Please take a look. Note that I won't land this in a while, because we ...
3 years, 4 months ago (2017-07-31 15:14:49 UTC) #11
Taylor Brandstetter
lgtm. What does the migration path look like? Could someone fork this code and continue ...
3 years, 4 months ago (2017-08-01 00:27:56 UTC) #14
daniela-webrtc
3 years, 4 months ago (2017-08-01 08:36:33 UTC) #15
lgtm

Powered by Google App Engine
This is Rietveld 408576698