GTK: reduce cpu usage of upgrade notification animation.

chrome/browser/gtk/browser_window_gtk.cc

Index: chrome/browser/gtk/browser_window_gtk.cc
diff --git a/chrome/browser/gtk/browser_window_gtk.cc b/chrome/browser/gtk/browser_window_gtk.cc
index be48032aff93bc0b0022041ff213a9b3b6fa23bc..24b012b440400ca71aba08a265a20c39c2b72e2e 100644
--- a/chrome/browser/gtk/browser_window_gtk.cc
+++ b/chrome/browser/gtk/browser_window_gtk.cc
@@ -333,6 +333,8 @@ BrowserWindowGtk::BrowserWindowGtk(Browser* browser)
        maximize_after_show_(false),
        suppress_window_raise_(false),
        accel_group_(NULL) {
+  ActiveWindowWatcherX::AddObserver(this);

[tony, 2010/07/13 22:09:47]

What is the reason for this move?  Should there be a comment explaining why this
needs to happen first?

[Evan Stade, 2010/07/13 22:29:40]

the reason is so that the observer gets called first and is_active() will be
updated by the time BrowserToolbarGtk is called back. I will add a comment.

+
   use_custom_frame_pref_.Init(prefs::kUseCustomChromeFrame,
       browser_->profile()->GetPrefs(), this);
 
@@ -374,8 +376,6 @@ BrowserWindowGtk::BrowserWindowGtk(Browser* browser)
 
   registrar_.Add(this, NotificationType::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED,
                  NotificationService::AllSources());
-
-  ActiveWindowWatcherX::AddObserver(this);
 }
 
 BrowserWindowGtk::~BrowserWindowGtk() {