GTK: reduce cpu usage of upgrade notification animation.

chrome/browser/gtk/browser_window_gtk.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/browser_window_gtk.h"
 
 #include <gdk/gdkkeysyms.h>
 
 #include <string>
 
@@ skipping 315 matching lines @@
 
 BrowserWindowGtk::BrowserWindowGtk(Browser* browser)
     :  browser_(browser),
        state_(GDK_WINDOW_STATE_WITHDRAWN),
        frame_cursor_(NULL),
        is_active_(true),
        last_click_time_(0),
        maximize_after_show_(false),
        suppress_window_raise_(false),
        accel_group_(NULL) {
+  ActiveWindowWatcherX::AddObserver(this);

[tony, 2010/07/13 22:09:47]

What is the reason for this move?  Should there be a comment explaining why this
needs to happen first?

[Evan Stade, 2010/07/13 22:29:40]

the reason is so that the observer gets called first and is_active() will be
updated by the time BrowserToolbarGtk is called back. I will add a comment.

+
   use_custom_frame_pref_.Init(prefs::kUseCustomChromeFrame,
       browser_->profile()->GetPrefs(), this);
 
   // In some (older) versions of compiz, raising top-level windows when they
   // are partially off-screen causes them to get snapped back on screen, not
   // always even on the current virtual desktop.  If we are running under
   // compiz, suppress such raises, as they are not necessary in compiz anyway.
   std::string wm_name;
   if (x11_util::GetWindowManagerName(&wm_name) && wm_name == "compiz")
     suppress_window_raise_ = true;
@@ skipping 21 matching lines @@
   }
 
   ConnectAccelerators();
 
   // Set the initial background color of widgets.
   SetBackgroundColor();
   HideUnsupportedWindowFeatures();
 
   registrar_.Add(this, NotificationType::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED,
                  NotificationService::AllSources());
-
-  ActiveWindowWatcherX::AddObserver(this);
 }
 
 BrowserWindowGtk::~BrowserWindowGtk() {
   ActiveWindowWatcherX::RemoveObserver(this);
 
   browser_->tabstrip_model()->RemoveObserver(this);
 
   if (frame_cursor_) {
     gdk_cursor_unref(frame_cursor_);
     frame_cursor_ = NULL;
@@ skipping 1761 matching lines @@
   // special-case the ones where the custom frame should be used.  These names
   // are taken from the WMs' source code.
   return (wm_name == "Blackbox" ||
           wm_name == "compiz" ||
           wm_name == "e16" ||  // Enlightenment DR16
           wm_name == "Metacity" ||
           wm_name == "Mutter" ||
           wm_name == "Openbox" ||
           wm_name == "Xfwm4");
 }