Issue 2980014: [Mac] Fix page-action positioning for flipped field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2980014: [Mac] Fix page-action positioning for flipped field. (Closed)

Created:
10 years, 5 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
Bons

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

[Mac] Fix page-action positioning for flipped field. My http://codereview.chromium.org/2998004 refactored calculation of the page-action info-bubble position, but didn't fully factor in a coordinate-system change. BUG=none TEST=Page-action info-bubble position at bottom, not top. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52438

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/cocoa/location_bar/location_bar_view_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Scott Hess - ex-Googler

Too much multi-tasking reduces your IQ. I've heard.

10 years, 5 months ago (2010-07-14 21:12:47 UTC) #1

LGTM