Issue 2998004: [Mac] Simplify getting page-action info-bubble point.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2998004: [Mac] Simplify getting page-action info-bubble point. (Closed)

Created:
10 years, 5 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
pink (ping after 24hrs), Bons

CC:
chromium-reviews, John Grabowski, Aaron Boodman, pam+watch_chromium.org, Erik does not do reviews, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

[Mac] Simplify getting page-action info-bubble point. LocationBarViewMac::GetPageActionBubblePoint() calculates the info-bubble point directly, rather than exposing multiple entry points so that extension code can calculate it. Also convert -locationBarBridge from returning |LocationBar*| to returning |LocationBarViewMac*|. Various code was doing static_cast<LocationBarViewMac*>() on the result, so it wasn't safe anyhow. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52378 [Closed manually, accidentally interrupted the git-cl dcommit.]

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -84 lines)			Patch
M	chrome/browser/cocoa/browser_window_controller.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.mm	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/extension_installed_bubble_controller.mm	View	3 chunks	+8 lines, -10 lines	0 comments	Download
M	chrome/browser/cocoa/extensions/extension_action_context_menu.mm	View	1 chunk	+9 lines, -19 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar/location_bar_view_mac.h	View	1 chunk	+3 lines, -8 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar/location_bar_view_mac.mm	View	2 chunks	+21 lines, -24 lines	0 comments	Download
M	chrome/browser/cocoa/toolbar_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/toolbar_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

Andy, because I think he wrote it. Pink, to see if the sense of the ...

10 years, 5 months ago (2010-07-14 13:12:20 UTC) #1

Scott Hess - ex-Googler

10 years, 5 months ago (2010-07-14 20:57:50 UTC) #3

On 2010/07/14 13:54:14, Andrew Bonventre (Bons) wrote:
> LGTM
> 
> Nice cleanup.

Crap.  I think I made a flipped-edness mistake.  And I wrote a darn extension
specifically for testing this stuff.

Expand Messages | Collapse Messages