Makes the auto fill dialogs match the mocks.

Makes the auto fill dialogs match the mocks.

BUG=44620
46634
TEST=Make sure the auto fill dialogs work correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52274

[James Hawkins, 2010-07-12 19:58:06]

LGTM with nits.

http://codereview.chromium.org/2975003/diff/2001/3001
File chrome/browser/autofill/auto_fill_editor_gtk.cc (right):

http://codereview.chromium.org/2975003/diff/2001/3001#newcode155
chrome/browser/autofill/auto_fill_editor_gtk.cc:155: // Sets the values of the
various widget to |profile|.
s/widget/widgets/

http://codereview.chromium.org/2975003/diff/2001/3001#newcode446
chrome/browser/autofill/auto_fill_editor_gtk.cc:446: 
Are these extra blank lines required?

http://codereview.chromium.org/2975003/diff/2001/3003
File chrome/browser/autofill/autofill_dialog_gtk.cc (right):

http://codereview.chromium.org/2975003/diff/2001/3003#newcode129
chrome/browser/autofill/autofill_dialog_gtk.cc:129: // Updates the state of the
various widget dependant upon the state of the
s/widget/widgets/

http://codereview.chromium.org/2975003/diff/2001/3003#newcode130
chrome/browser/autofill/autofill_dialog_gtk.cc:130: // selection, loaded state
and whether autofill is enabled.
s/autofill/AutoFill/ here and elsewhere.

[James Hawkins, 2010-07-12 23:00:55]

Keep crbug.com/46634 in mind. I think we're hitting that bug with the current
patch set.

[sky, 2010-07-12 23:41:10]

Since I haven't landed this yet I've updated it to fix 46634. Take another look?

Thanks,

  -Scott

[sky, 2010-07-12 23:43:03]

Also, ignore the name of the patch. That's the wrong bug #. Sorry.

  -Scott

On Mon, Jul 12, 2010 at 4:41 PM, Scott Violet <sky@chromium.org> wrote:
> Since I haven't landed this yet I've updated it to fix 46634. Take another
look?
>
> Thanks,
>
>  -Scott
>

[James Hawkins, 2010-07-12 23:45:20]

LGTM, and we talked offline about moving the function definitions out of
autofill_dialog.h, so that LGTM to.

http://codereview.chromium.org/2975003/diff/7002/9001
File chrome/browser/autofill/auto_fill_editor_gtk.cc (right):

http://codereview.chromium.org/2975003/diff/7002/9001#newcode172
chrome/browser/autofill/auto_fill_editor_gtk.cc:172: // when no empty.
s/no/not/?