Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/browser/autofill/autofill_dialog.h

Issue 2975003: Makes the auto fill dialogs match the mocks. (Closed)
Patch Set: Moves function declarations out of autofill_dialog.h Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/auto_fill_editor_gtk.cc ('k') | chrome/browser/autofill/autofill_dialog_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_dialog.h
diff --git a/chrome/browser/autofill/autofill_dialog.h b/chrome/browser/autofill/autofill_dialog.h
index 5e1a530bba6837d4cc0f7dbc14ff6d242a7d0af7..de70e533fa838bbd0f2cd20d32d10cfb78d4c485 100644
--- a/chrome/browser/autofill/autofill_dialog.h
+++ b/chrome/browser/autofill/autofill_dialog.h
@@ -18,7 +18,9 @@ class Profile;
class AutoFillDialogObserver {
public:
// The user has confirmed changes by clicking "Apply" or "OK". Any of the
- // parameters may be NULL.
+ // parameters may be NULL. A NULL parameter is treated as not changing the
+ // existing data. For example, |OnAutoFillDialogApply(new_profiles, NULL)|
+ // only sets the profiles and not the credit cards.
virtual void OnAutoFillDialogApply(
std::vector<AutoFillProfile>* profiles,
std::vector<CreditCard>* credit_cards) = 0;
@@ -28,9 +30,9 @@ class AutoFillDialogObserver {
};
// Shows the AutoFill dialog, which allows the user to edit profile information.
-// |profile| is profile from which you can get vectors of of autofill profiles
-// that contains the current profile information and credit cards.
-// The dialog fills out the profile fields using this data.
+// |profile| is profile from which you can get vectors of autofill profiles that
+// contains the current profile information and credit cards. The dialog fills
+// out the profile fields using this data.
//
// |observer| will be notified by OnAutoFillDialogAccept when the user has
// applied changes. May not be NULL.
« no previous file with comments | « chrome/browser/autofill/auto_fill_editor_gtk.cc ('k') | chrome/browser/autofill/autofill_dialog_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698