Issue 2973005: fixed vm scripts

Issue 2973005: fixed vm scripts (Closed)

Created:
10 years, 5 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
rkc1

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://gitrw.chromium.org/crosutils.git

Visibility:
Public.

Patch Set 3 : fixes #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	fixup_image_for_qemu.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	image_to_vm.sh	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rkc1

Additionally, there is one more problem with the postinst script) - it's fixed in http://codereview.chromium.org/2895009/show ...

10 years, 5 months ago (2010-07-12 13:59:40 UTC) #2

zel

http://codereview.chromium.org/2973005/diff/1/2 File fixup_image_for_qemu.py (right): http://codereview.chromium.org/2973005/diff/1/2#newcode116 fixup_image_for_qemu.py:116: postinst = '. "$(dirname "$0")/usr/sbin/chromeos-common.sh"' + "\n" + \ ...

10 years, 5 months ago (2010-07-13 01:08:22 UTC) #3

rkc1

10 years, 5 months ago (2010-07-13 09:20:16 UTC) #4

LGTM

On 2010/07/13 01:08:22, zel wrote:
> http://codereview.chromium.org/2973005/diff/1/2
> File fixup_image_for_qemu.py (right):
> 
> http://codereview.chromium.org/2973005/diff/1/2#newcode116
> fixup_image_for_qemu.py:116: postinst = '. "$(dirname
> "$0")/usr/sbin/chromeos-common.sh"' + "\n" + \
> On 2010/07/12 13:59:40, rkc wrote:
> > Not sure if we still need this. Bill fixed it in
> > http://codereview.chromium.org/2872019
> > 
> 
> Done.
> 
> http://codereview.chromium.org/2973005/diff/1/3
> File image_to_vm.sh (right):
> 
> http://codereview.chromium.org/2973005/diff/1/3#newcode161
> image_to_vm.sh:161: #sudo "${TEMP_MNT}"/postinst_vm "${ROOTFS_PARTITION}"
> On 2010/07/12 13:59:40, rkc wrote:
> > This needs to be uncommented - the VM won't boot if it's extlinux.conf isn't
> > setup.
> 
> Done.

Expand Messages | Collapse Messages