Issue 2872019: Sigh. Source the chromeos-common.sh script in postinst.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2872019: Sigh. Source the chromeos-common.sh script in postinst. (Closed)

Created:
10 years, 5 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Chris Masone, petkov, ericli, DaveMoore

CC:
chromium-os-reviews_chromium.org, prigge

Base URL:
ssh://git@chromiumos-git//installer.git

Visibility:
Public.

Description

Sigh. Source the chromeos-common.sh script in postinst. First, un-revert Dave's change (cc61808d4d5d9daf3478a779f376cb9eee5d1a8b) that reverted the broken commit (185fa14370df286ab9892025d329a47d91fa66ed), then make sure the helper functions are defined before we use them. This doesn't fix the image-to-vmware problem but that's in another repo, so it will take another CL. Review URL: http://codereview.chromium.org/2742009

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -15 lines)			Patch
	M	chromeos-postinst	View		3 chunks	+18 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages