Issue 2966008: Fix selection of download URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2966008: Fix selection of download URLs (Closed)

Created:
10 years, 5 months ago by feldstein

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, Paul Godavari, arv (Not doing code reviews), ben+cc_chromium.org

Visibility:
Public.

Description

Fix selection of download URLs In progress downloads would clear the selection of the url every time the progress updates, making it impossible to copy a url. BUG=44982 TEST=Download a large file, and select it's URL as it is downloading. It should stay selected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52267

Patch Set 1 #

Total comments: 1

Patch Set 2 : add comment #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/resources/downloads.html	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

10 years, 5 months ago (2010-07-13 22:45:51 UTC) #2

LGTM

http://codereview.chromium.org/2966008/diff/1/2
File chrome/browser/resources/downloads.html (right):

http://codereview.chromium.org/2966008/diff/1/2#newcode588
chrome/browser/resources/downloads.html:588: if (this.nodeURL_.textContent !=
this.url_)
Do you mind adding a comment?

Expand Messages | Collapse Messages