Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/browser/resources/downloads.html

Issue 2966008: Fix selection of download URLs (Closed)
Patch Set: add comment Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/downloads.html
diff --git a/chrome/browser/resources/downloads.html b/chrome/browser/resources/downloads.html
index 0cfbae5be5c14c141ead42b599294d195e087a11..fa4008fd3a30da0d8bef410c62997ae15136a1ee 100644
--- a/chrome/browser/resources/downloads.html
+++ b/chrome/browser/resources/downloads.html
@@ -585,7 +585,10 @@ Download.prototype.update = function(download) {
this.nodeSince_.innerHTML = this.since_;
this.nodeDate_.innerHTML = this.date_;
- this.nodeURL_.textContent = this.url_;
+ // Don't unnecessarily update the url, as doing so will remove any
+ // text selection the user has started (http://crbug.com/44982).
+ if (this.nodeURL_.textContent != this.url_)
+ this.nodeURL_.textContent = this.url_;
this.nodeStatus_.innerHTML = this.getStatusText_();
this.danger_.style.display = 'none';
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698