Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 2961004: Plugin: Remove __socketAddressFactory() and toString() on SocketAddresses (Closed)

Created:
10 years, 5 months ago by Mark Seaborn
Modified:
9 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Plugin: Remove __socketAddressFactory() and toString() on SocketAddresses In order for NaCl to work in Chromium's Mac sandbox and Linux seccomp sandbox, we need to remove the ability to convert SocketAddress descriptors to strings and back again. The first step is to remove the interfaces that are exposed to web apps via the plugin. After this we will change the implementation of SocketAddress and BoundSocket descriptors. BUG=http://code.google.com/p/nativeclient/issues/detail?id=344 Committed: http://code.google.com/p/nativeclient/source/detail?r=2656

Patch Set 1 #

Patch Set 2 : Apply HTML changes to copies in "prebuilt" too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -591 lines) Patch
M src/native_client/src/trusted/desc/nacl_desc_wrapper.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/native_client/src/trusted/desc/nacl_desc_wrapper.cc View 2 chunks +0 lines, -52 lines 0 comments Download
M src/native_client/src/trusted/plugin/srpc/plugin.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M src/native_client/src/trusted/plugin/srpc/socket_address.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M src/native_client/tests/prebuilt/x64/srpc_basic.html View 2 chunks +0 lines, -3 lines 0 comments Download
M src/native_client/tests/prebuilt/x64/srpc_sockaddr.html View 9 chunks +0 lines, -158 lines 0 comments Download
M src/native_client/tests/prebuilt/x86/srpc_basic.html View 2 chunks +0 lines, -3 lines 0 comments Download
M src/native_client/tests/prebuilt/x86/srpc_sockaddr.html View 9 chunks +0 lines, -158 lines 0 comments Download
M src/native_client/tests/srpc/srpc_basic.html View 2 chunks +0 lines, -3 lines 0 comments Download
M src/native_client/tests/srpc/srpc_sockaddr.html View 9 chunks +0 lines, -158 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
Mark S persuaded me to take on another piece of work...
10 years, 5 months ago (2010-07-12 14:53:54 UTC) #1
Mark Schneckloth
10 years, 5 months ago (2010-07-12 17:59:46 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698