Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: src/native_client/src/trusted/plugin/srpc/socket_address.cc

Issue 2961004: Plugin: Remove __socketAddressFactory() and toString() on SocketAddresses (Closed)
Patch Set: Apply HTML changes to copies in "prebuilt" too Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/native_client/src/trusted/plugin/srpc/socket_address.cc
diff --git a/src/native_client/src/trusted/plugin/srpc/socket_address.cc b/src/native_client/src/trusted/plugin/srpc/socket_address.cc
index b1b14d25e734c48cb19045c559a6f8befc061d4a..2b46c4c56843bb247acca509929afc409aaf98e0 100644
--- a/src/native_client/src/trusted/plugin/srpc/socket_address.cc
+++ b/src/native_client/src/trusted/plugin/srpc/socket_address.cc
@@ -30,25 +30,6 @@ bool RpcConnect(void* obj, plugin::SrpcParams *params) {
return true;
}
-bool RpcToString(void* obj, plugin::SrpcParams *params) {
- plugin::SocketAddress* socket_addr =
- reinterpret_cast<plugin::SocketAddress*>(obj);
- const char* str = socket_addr->wrapper()->conn_cap_path();
- if (NULL == str) {
- return false;
- }
- size_t len = strnlen(str, NACL_PATH_MAX);
- // strnlen ensures that len <= NACL_PATH_MAX < SIZE_T_MAX, so no overflow.
- char* ret_string = reinterpret_cast<char*>(malloc(len + 1));
- if (NULL == ret_string) {
- return false;
- }
- strncpy(ret_string, str, len + 1);
- params->outs()[0]->tag = NACL_SRPC_ARG_TYPE_STRING;
- params->outs()[0]->u.sval = ret_string;
- return true;
-}
-
} // namespace
namespace plugin {
@@ -74,7 +55,6 @@ bool SocketAddress::Init(Plugin* plugin, nacl::DescWrapper* wrapper) {
void SocketAddress::LoadMethods() {
// Methods implemented by SocketAddresses.
AddMethodCall(RpcConnect, "connect", "", "h");
- AddMethodCall(RpcToString, "toString", "", "s");
}
SocketAddress::SocketAddress() {
« no previous file with comments | « src/native_client/src/trusted/plugin/srpc/plugin.cc ('k') | src/native_client/tests/prebuilt/x64/srpc_basic.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698