Issue 295051: Constrain extension popups to a min/max size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295051: Constrain extension popups to a min/max size (Closed)

Created:
11 years, 2 months ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Constrain extension popups to a min/max size. Also, fix some glitches in sizing the popups. BUG=25214 TEST=ExtensionApiTest.BrowserActionPopup Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30346

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -17 lines)			Patch
M	chrome/browser/extensions/browser_action_apitest.cc	View	1 chunk	+30 lines, -5 lines	1 comment	Download
M	chrome/browser/views/browser_bubble.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/views/extensions/extension_popup.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/views/extensions/extension_popup.cc	View	4 chunks	+20 lines, -5 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/popup/popup.html	View	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

I disagree that we should have a max size on popups, especially if it's arbitrary. ...

11 years, 2 months ago (2009-10-22 00:16:19 UTC) #1

Aaron Boodman

11 years, 2 months ago (2009-10-22 00:20:40 UTC) #2

On 2009/10/22 00:16:19, Matt Perry wrote:
> I disagree that we should have a max size on popups, especially if it's
> arbitrary. Unless we have a reasonable max, like something relative to the
> user's screen or chrome window size, it's meaninglessly restrictive.
> 
> http://codereview.chromium.org/295051/diff/1/2
> File chrome/browser/extensions/browser_action_apitest.cc (right):
> 
> http://codereview.chromium.org/295051/diff/1/2#newcode110
> Line 110: ASSERT_GT(ExtensionPopup::kMinHeight + growFactor * 2,
> I think you mean just growFactor*2 here.

The problem with doing some percentage of the browser window is that it's hard
for users to know whether their UI will fit.

I think a very large hardcoded max size is a reasonable start.

Expand Messages | Collapse Messages