Constrain extension popups to a min/max size

chrome/browser/extensions/browser_action_apitest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_window.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_browser_event_router.h"
 #include "chrome/browser/extensions/extension_tabs_module.h"
 #include "chrome/browser/extensions/extensions_service.h"
@@ skipping 87 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, BrowserActionPopup) {
   ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("popup")));
 
   ResultCatcher catcher;
   BrowserActionsContainer* browser_actions =
       browser()->window()->GetBrowserWindowTesting()->GetToolbarView()->
       browser_actions();
 
+  // This value is in api_test/popup/popup.html.
+  const int growFactor = 500;
+  ASSERT_GT(ExtensionPopup::kMinHeight + growFactor * 2,

[Matt Perry, 2009/10/22 00:16:19]

I think you mean just growFactor*2 here.

+            ExtensionPopup::kMaxHeight);
+  ASSERT_GT(ExtensionPopup::kMinWidth + growFactor * 2,
+            ExtensionPopup::kMaxWidth);
+
+  // Our initial expected size.
+  int width = ExtensionPopup::kMinWidth;
+  int height = ExtensionPopup::kMinHeight;
+
   // Simulate a click on the browser action and verify the size of the resulting
-  // popup.
+  // popup.  The first one tries to be 0x0, so it should be the min values.
   browser_actions->TestExecuteBrowserAction(0);
   EXPECT_TRUE(browser_actions->TestGetPopup() != NULL);
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
   gfx::Rect bounds = browser_actions->TestGetPopup()->view()->bounds();
-  EXPECT_EQ(100, bounds.width());
-  EXPECT_EQ(100, bounds.height());
+  EXPECT_EQ(width, bounds.width());
+  EXPECT_EQ(height, bounds.height());
   browser_actions->HidePopup();
   EXPECT_TRUE(browser_actions->TestGetPopup() == NULL);
 
   // Do it again, and verify the new bigger size (the popup grows each time it's
   // opened).
+  width = growFactor;
+  height = growFactor;
   browser_actions->TestExecuteBrowserAction(0);
   EXPECT_TRUE(browser_actions->TestGetPopup() != NULL);
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
   bounds = browser_actions->TestGetPopup()->view()->bounds();
-  EXPECT_EQ(200, bounds.width());
-  EXPECT_EQ(200, bounds.height());
+  EXPECT_EQ(width, bounds.width());
+  EXPECT_EQ(height, bounds.height());
+  browser_actions->HidePopup();
+  EXPECT_TRUE(browser_actions->TestGetPopup() == NULL);
+
+  // One more time, but this time it should be constrained by the max values.
+  width = ExtensionPopup::kMaxWidth;
+  height = ExtensionPopup::kMaxHeight;
+  browser_actions->TestExecuteBrowserAction(0);
+  EXPECT_TRUE(browser_actions->TestGetPopup() != NULL);
+  ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
+  bounds = browser_actions->TestGetPopup()->view()->bounds();
+  EXPECT_EQ(width, bounds.width());
+  EXPECT_EQ(height, bounds.height());
   browser_actions->HidePopup();
   EXPECT_TRUE(browser_actions->TestGetPopup() == NULL);
 }