Deprecate PathService::Get(..., wstring*) and use FilePath instead.

Deprecate PathService::Get(..., wstring*) and use FilePath instead.

I tried fixing all the Windows code but there's a *ton* of it.
This change will at least prevent people from adding new code that
uses the deprecated version (as that won't compile on Lin/Mac).

BUG=24672
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29472

[Evan Martin, 2009-10-19 22:42:28]

victory

[tony, 2009-10-19 22:46:49]

LGTM, 2 nits below.

http://codereview.chromium.org/293013/diff/1/3
File base/i18n/icu_util.cc (right):

http://codereview.chromium.org/293013/diff/1/3#newcode61
Line 61: data_path =
data_path.Append(ASCIIToWide(ICU_UTIL_DATA_SHARED_MODULE_NAME));
Nit: AppendASCII?

http://codereview.chromium.org/293013/diff/1/13
File chrome/test/ui/ui_test.cc (right):

http://codereview.chromium.org/293013/diff/1/13#newcode649
Line 649: path = path.AppendASCII(WideToASCII(chrome::kNotSignedInProfile));
tears :(

http://codereview.chromium.org/293013/diff/1/14
File webkit/glue/plugins/plugin_list_win.cc (right):

http://codereview.chromium.org/293013/diff/1/14#newcode127
Line 127: firefox_app_data_plugin_path.AppendASCII("Mozilla/plugins");
Is it safe to embed the '/' here or do you need to call AppendASCII twice?

[Evan Stade, 2009-10-19 22:54:31]

lgtm as well

http://codereview.chromium.org/293013/diff/1/11
File chrome/browser/user_data_manager.cc (right):

http://codereview.chromium.org/293013/diff/1/11#newcode32
Line 32: // TODO: don't use wstrings in all this code.  :(
TODO(evan)

http://codereview.chromium.org/293013/diff/1/14
File webkit/glue/plugins/plugin_list_win.cc (right):

http://codereview.chromium.org/293013/diff/1/14#newcode127
Line 127: firefox_app_data_plugin_path.AppendASCII("Mozilla/plugins");
<bikeshedding>

I agree AppendASCII twice is probably better, but since this is Windows-only you
can use Append with a wide literal string

</bikeshedding>