Convert some tools to use FilePaths for file names.

Convert some helper tools to use FilePaths for file names.

Add a "PRFilePath" macro to file_path.h for use in printf'ing
a FilePath.

These are some of the last users of deprecated file_util functions
(e.g. OpenFile(wstring, ...)).

BUG=24672
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52391

[Evan Martin, 2010-07-08 19:11:50]

I implemented your suggestions.

[Evan Martin, 2010-07-08 19:21:09]

Hold off on reviewing, I'll ping again once I've sorted out trybots.

[Mark Mentovai, 2010-07-08 20:28:30]

I’ll take another look when you’re ready, but…

http://codereview.chromium.org/2929002/diff/1/2
File base/file_path.h (right):

http://codereview.chromium.org/2929002/diff/1/2#newcode362
base/file_path.h:362: #define PRFilePath "%s"
Don’t put the % here, because the <inttypes.h> PR* family of macros doesn’t, and
for the same reason, Chrome’s macros such as PRIuS in base/format_macros.h
doesn’t either.

[Evan Martin, 2010-07-12 21:37:54]

OK, trybots worked (for as much as they "work", that is to say, compiled)

[Mark Mentovai, 2010-07-12 21:45:19]

http://codereview.chromium.org/2929002/diff/9001/10004
File chrome/tools/convert_dict/convert_dict.cc (right):

http://codereview.chromium.org/2929002/diff/9001/10004#newcode97
chrome/tools/convert_dict/convert_dict.cc:97: FilePath file_base =
FilePath(argv[1]);
#include "base/file_path.h"?

http://codereview.chromium.org/2929002/diff/9001/10008
File tools/imagediff/image_diff.cc (right):

http://codereview.chromium.org/2929002/diff/9001/10008#newcode329
tools/imagediff/image_diff.cc:329: // paths as non-wide strings anyway.
Who writes to this?

http://codereview.chromium.org/2929002/diff/9001/10008#newcode330
tools/imagediff/image_diff.cc:330: FilePath FilePathFromASCII(const std::string&
str) {
static or anonymous namespace?

[Evan Martin, 2010-07-12 21:50:40]

http://codereview.chromium.org/2929002/diff/9001/10004
File chrome/tools/convert_dict/convert_dict.cc (right):

http://codereview.chromium.org/2929002/diff/9001/10004#newcode97
chrome/tools/convert_dict/convert_dict.cc:97: FilePath file_base =
FilePath(argv[1]);
On 2010/07/12 21:45:19, Mark Mentovai wrote:
> #include "base/file_path.h"?

Done.

http://codereview.chromium.org/2929002/diff/9001/10008
File tools/imagediff/image_diff.cc (right):

http://codereview.chromium.org/2929002/diff/9001/10008#newcode329
tools/imagediff/image_diff.cc:329: // paths as non-wide strings anyway.
On 2010/07/12 21:45:19, Mark Mentovai wrote:
> Who writes to this?

Some of the WebKit layout test scripts, presumably.

http://codereview.chromium.org/2929002/diff/9001/10008#newcode330
tools/imagediff/image_diff.cc:330: FilePath FilePathFromASCII(const std::string&
str) {
On 2010/07/12 21:45:19, Mark Mentovai wrote:
> static or anonymous namespace?

I considered it, but I thought to be consistent with the file style.

[Mark Mentovai, 2010-07-12 21:54:37]

LGTM