chrome/tools/convert_dict/dic_reader.cc - Issue 2929002: Convert some tools to use FilePaths for file names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/convert_dict/dic_reader.cc

Issue 2929002: Convert some tools to use FilePaths for file names. (Closed)

Patch Set: ok Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/tools/convert_dict/dic_reader.cc

diff --git a/chrome/tools/convert_dict/dic_reader.cc b/chrome/tools/convert_dict/dic_reader.cc

index 38400a9d1775bb80083a9254806a6e6a222e3a79..c8ee113cc521eb8131d4bc25c5ba6cf2d29fa14e 100644

--- a/chrome/tools/convert_dict/dic_reader.cc

+++ b/chrome/tools/convert_dict/dic_reader.cc

@@ -128,8 +128,7 @@ bool PopulateWordSet(WordSet* word_set, FILE* file, AffReader* aff_reader,

} // namespace

-DicReader::DicReader(const std::string& filename) {

- FilePath path = FilePath::FromWStringHack(ASCIIToWide(filename));

+DicReader::DicReader(const FilePath& path) {

file_ = file_util::OpenFile(path, "r");

FilePath additional_path =

« no previous file with comments | « chrome/tools/convert_dict/dic_reader.h ('k') | tools/imagediff/image_diff.cc » ('j') | no next file with comments »