Parse input with explicit schemes better. Before, if the user typed "http://...

Parse input with explicit schemes better.  Before, if the user typed "http://..." we always parsed as a URL.  Now we parse more like we would without the scheme, so that we can reject various kinds of invalid inputs.

BUG=none
TEST=Input "http://foo:bar" (without quotes) in the address bar, and the default action should be search, not navigate.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29450

[Peter Kasting, 2009-10-16 23:21:20]

Note: This will not pass unit tests until http://codereview.chromium.org/291005
lands.

[brettw, 2009-10-17 04:24:09]

LGTM, thanks for the clear comments.

http://codereview.chromium.org/292003/diff/1/3
File chrome/browser/autocomplete/autocomplete_unittest.cc (right):

http://codereview.chromium.org/292003/diff/1/3#newcode248
Line 248: { L"http://user@foo.com", AutocompleteInput::URL },
Can you add the case "http:host" and "http:user@host" and "http:ps/2 games"
(i.e. makes sure the double slash isn't necessary to affect the outcome).

[Peter Kasting, 2009-10-19 20:12:30]

On 2009/10/17 04:24:09, brettw wrote:
> http://codereview.chromium.org/292003/diff/1/3#newcode248
> Line 248: { L"http://user@foo.com", AutocompleteInput::URL },
> Can you add the case "http:host" and "http:user@host" and "http:ps/2 games"
> (i.e. makes sure the double slash isn't necessary to affect the outcome).

Done.  Landing.