Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3975)

Unified Diff: chrome/browser/autocomplete/autocomplete_unittest.cc

Issue 292003: Parse input with explicit schemes better. Before, if the user typed "http://... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/autocomplete.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_unittest.cc
===================================================================
--- chrome/browser/autocomplete/autocomplete_unittest.cc (revision 29420)
+++ chrome/browser/autocomplete/autocomplete_unittest.cc (working copy)
@@ -210,6 +210,7 @@
{ L"?foo bar", AutocompleteInput::FORCED_QUERY },
{ L"?http://foo.com/bar", AutocompleteInput::FORCED_QUERY },
{ L"foo", AutocompleteInput::UNKNOWN },
+ { L"foo.c", AutocompleteInput::UNKNOWN },
{ L"foo.com", AutocompleteInput::URL },
{ L"-.com", AutocompleteInput::QUERY },
{ L"foo/bar", AutocompleteInput::URL },
@@ -222,6 +223,11 @@
{ L"localhost:8080", AutocompleteInput::URL },
{ L"foo.com:123456", AutocompleteInput::QUERY },
{ L"foo.com:abc", AutocompleteInput::QUERY },
+ { L"user@foo.com", AutocompleteInput::UNKNOWN },
+ { L"user:pass@foo.com", AutocompleteInput::UNKNOWN },
+ { L"1.2", AutocompleteInput::UNKNOWN },
+ { L"1.2/45", AutocompleteInput::UNKNOWN },
+ { L"ps/2 games", AutocompleteInput::UNKNOWN },
{ L"en.wikipedia.org/wiki/James Bond", AutocompleteInput::URL },
// In Chrome itself, mailto: will get handled by ShellExecute, but in
// unittest mode, we don't have the data loaded in the external protocol
@@ -233,7 +239,20 @@
{ L"C:\\Program Files", AutocompleteInput::URL },
{ L"\\\\Server\\Folder\\File", AutocompleteInput::URL },
#endif // defined(OS_WIN)
- { L"http://foo.com/", AutocompleteInput::URL },
+ { L"http:foo", AutocompleteInput::URL },
+ { L"http://foo", AutocompleteInput::URL },
+ { L"http://foo.c", AutocompleteInput::URL },
+ { L"http://foo.com", AutocompleteInput::URL },
+ { L"http://-.com", AutocompleteInput::QUERY },
+ { L"http://foo.com:abc", AutocompleteInput::QUERY },
+ { L"http://foo.com:123456", AutocompleteInput::QUERY },
+ { L"http:user@foo.com", AutocompleteInput::URL },
+ { L"http://user@foo.com", AutocompleteInput::URL },
+ { L"http://user:pass@foo.com", AutocompleteInput::URL },
+ { L"http://1.2", AutocompleteInput::URL },
+ { L"http://1.2/45", AutocompleteInput::URL },
+ { L"http:ps/2 games", AutocompleteInput::URL },
+ { L"http://ps/2 games", AutocompleteInput::URL },
{ L"127.0.0.1", AutocompleteInput::URL },
{ L"127.0.1", AutocompleteInput::UNKNOWN },
{ L"127.0.1/", AutocompleteInput::UNKNOWN },
« no previous file with comments | « chrome/browser/autocomplete/autocomplete.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698