Issue 289003: prtypes.h followup cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 289003: prtypes.h followup cleanup (Closed)

Created:
11 years, 2 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adjust comment following r29182 post-commit feedback. Put now-unused macros back to how they are upstream. BUG=24911 TEST=none r29328

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	base/third_party/nspr/prtypes.h	View		2 chunks	+6 lines, -7 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

http://codereview.chromium.org/289003/diff/1/2 File base/third_party/nspr/prtypes.h (right): http://codereview.chromium.org/289003/diff/1/2#newcode119 Line 119: #define PR_IMPORT_DATA(__type) __declspec(dllimport) __type Note that WIN32 doesn't ...

11 years, 2 months ago (2009-10-16 19:15:28 UTC) #1

LGTM.  Thank you, Mark!

Expand Messages | Collapse Messages