Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1808)

Unified Diff: base/third_party/nspr/prtypes.h

Issue 289003: prtypes.h followup cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/third_party/nspr/prtypes.h
===================================================================
--- base/third_party/nspr/prtypes.h (revision 29289)
+++ base/third_party/nspr/prtypes.h (working copy)
@@ -91,11 +91,10 @@
#if 1
/*
-** Chrome-local change: the portions of NSPR used for Chrome are
-** implementation details of Chrome's base module. NSPR symbols do not need
-** to be exported beyond the module in which they are used. For all
-** platforms, avoid decorating functions with specific visibility and access
-** keywords.
+** Local change: the portions of NSPR used by the base module are
+** implementation details. NSPR symbols do not need to be exported beyond
+** the base module. For all platforms, avoid decorating functions with
+** specific visibility and access keywords.
*/
#define PR_EXPORT(__type) extern __type
@@ -116,11 +115,11 @@
#define PR_EXPORT(__type) extern __declspec(dllexport) __type
#define PR_EXPORT_DATA(__type) extern __declspec(dllexport) __type
-#define PR_IMPORT(__type) extern __type
+#define PR_IMPORT(__type) __declspec(dllimport) __type
#define PR_IMPORT_DATA(__type) __declspec(dllimport) __type
Mark Mentovai 2009/10/16 19:15:29 Note that WIN32 doesn't use extern here, but we're
#define PR_EXTERN(__type) extern __declspec(dllexport) __type
-#define PR_IMPLEMENT(__type) __type
+#define PR_IMPLEMENT(__type) __declspec(dllexport) __type
#define PR_EXTERN_DATA(__type) extern __declspec(dllexport) __type
#define PR_IMPLEMENT_DATA(__type) __declspec(dllexport) __type
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698