Issue 2884047: Revert 53990 - - Implement proxy settings dialog for Linux/Windows....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2884047: Revert 53990 - - Implement proxy settings dialog for Linux/Windows.... (Closed)

Created:
10 years, 4 months ago by Alexander Potapenko

Modified:
9 years, 6 months ago

Reviewers:
csilv

CC:
chromium-reviews, pam+watch_chromium.org, dhg, arv (Not doing code reviews), John Grabowski, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 53990 - - Implement proxy settings dialog for Linux/Windows. - Omit Network and SSL sections for ChromeOS. BUG=49038 TEST=Exercise proxy settings dialog in dom-ui options window (--enable-tabbed-options). Review URL: http://codereview.chromium.org/2847061 TBR=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54137

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -329 lines)			Patch
M	chrome/browser/dom_ui/advanced_options_handler.h	View	3 chunks	+12 lines, -10 lines	0 comments	Download
M	chrome/browser/dom_ui/advanced_options_handler.cc	View	5 chunks	+34 lines, -22 lines	0 comments	Download
D	chrome/browser/dom_ui/advanced_options_utils.h	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	chrome/browser/dom_ui/advanced_options_utils_gtk.cc	View	1 chunk	+0 lines, -132 lines	0 comments	Download
M	chrome/browser/dom_ui/advanced_options_utils_mac.mm	View	2 chunks	+3 lines, -5 lines	0 comments	Download
D	chrome/browser/dom_ui/advanced_options_utils_win.cc	View	1 chunk	+0 lines, -67 lines	0 comments	Download
M	chrome/browser/resources/options/advanced_options.html	View	4 chunks	+50 lines, -56 lines	0 comments	Download
M	chrome/browser/resources/options/advanced_options.js	View	2 chunks	+6 lines, -9 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 2 (0 generated)