Implement dom-ui proxy settings dialog for Linux/Windows....

- Implement proxy settings dialog for Linux/Windows.
- Omit Network and SSL sections for ChromeOS.

BUG=49038
TEST=Exercise proxy settings dialog in dom-ui options window (--enable-tabbed-options).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53990

[csilv, 2010-07-21 20:52:43]

+zel for review.

(note: latest windows trybot failure appears to be flake, previous was
successful.  queued up again for sanity.)

[csilv, 2010-07-22 22:11:49]

+stuartmorgan, +jhawkins as reviewers.

(This CL has little to do with the DOM-UI, it's really the platform specific
stuff for displaying proxy settings on Mac/Windows/Linux.  CrOS will be
implemented separately in DOM-UI by dhg.)

[stuartmorgan, 2010-07-22 22:32:16]

Can you convert advanced_options_utils_mac.h to advanced_options_utils.h, and
then move all the platform stuff into platform-specific implementations? I know
that not all platforms will have exactly the same methods, but at least there
will be some overlap, and the rest can be ifdef'd in the header.

[zel, 2010-07-22 23:17:34]

http://codereview.chromium.org/2847061/diff/12001/13002
File chrome/browser/dom_ui/advanced_options_handler.h (right):

http://codereview.chromium.org/2847061/diff/12001/13002#newcode58
chrome/browser/dom_ui/advanced_options_handler.h:58: 
let's exclude these two functions out of OS_CHROMEOS completely since we are
building a special DOM UI for that purpose

[csilv, 2010-07-23 00:15:41]

http://codereview.chromium.org/2847061/diff/12001/13002
File chrome/browser/dom_ui/advanced_options_handler.h (right):

http://codereview.chromium.org/2847061/diff/12001/13002#newcode58
chrome/browser/dom_ui/advanced_options_handler.h:58: 
On 2010/07/22 23:17:34, zel wrote:
> let's exclude these two functions out of OS_CHROMEOS completely since we are
> building a special DOM UI for that purpose

dhg indicated that the ChromeOS dialogs would invoked from this top level panel.
 If that's the case then we need these methods.  can you confirm?

[zel, 2010-07-23 01:08:02]

We will move this functionality to another tab first (Network settings) and
implement it as additional sub-pages / overlays.

On Thu, Jul 22, 2010 at 5:15 PM, <csilv@chromium.org> wrote:

>
> http://codereview.chromium.org/2847061/diff/12001/13002
> File chrome/browser/dom_ui/advanced_options_handler.h (right):
>
> http://codereview.chromium.org/2847061/diff/12001/13002#newcode58
> chrome/browser/dom_ui/advanced_options_handler.h:58:
> On 2010/07/22 23:17:34, zel wrote:
>
>> let's exclude these two functions out of OS_CHROMEOS completely since
>>
> we are
>
>> building a special DOM UI for that purpose
>>
>
> dhg indicated that the ChromeOS dialogs would invoked from this top
> level panel.  If that's the case then we need these methods.  can you
> confirm?
>
>
> http://codereview.chromium.org/2847061/show
>

[csilv, 2010-07-27 23:00:05]

Zel, Stuart, re-worked this CL to move platform specific code for SSL & proxy
settings into utilities.  Should be much more readable now.  Also disabled
options that will not be needed for CrOS.  Please take another look.  thx.

[csilv, 2010-07-27 23:01:31]

(FYI, just noticed that I have a couple of lint warnings.  Will resolve those
before submitting this CL.)

[stuartmorgan, 2010-07-28 17:25:23]

LGTM

http://codereview.chromium.org/2847061/diff/48002/51005
File chrome/browser/dom_ui/advanced_options_utils_gtk.cc (right):

http://codereview.chromium.org/2847061/diff/48002/51005#newcode34
chrome/browser/dom_ui/advanced_options_utils_gtk.cc:34:
"http://code.google.com/p/chromium/wiki/LinuxCertManagement";
Indent 4.

http://codereview.chromium.org/2847061/diff/48002/51005#newcode76
chrome/browser/dom_ui/advanced_options_utils_gtk.cc:76: PageTransition::LINK);
Align to just inside the opening paren.

[csilv, 2010-07-28 18:30:54]

http://codereview.chromium.org/2847061/diff/48002/51005
File chrome/browser/dom_ui/advanced_options_utils_gtk.cc (right):

http://codereview.chromium.org/2847061/diff/48002/51005#newcode34
chrome/browser/dom_ui/advanced_options_utils_gtk.cc:34:
"http://code.google.com/p/chromium/wiki/LinuxCertManagement";
On 2010/07/28 17:25:23, stuartmorgan wrote:
> Indent 4.

Done.

http://codereview.chromium.org/2847061/diff/48002/51005#newcode76
chrome/browser/dom_ui/advanced_options_utils_gtk.cc:76: PageTransition::LINK);
On 2010/07/28 17:25:23, stuartmorgan wrote:
> Align to just inside the opening paren.

Done.