Issue 2879004: Revert 50913...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2879004: Revert 50913... (Closed)

Created:
10 years, 6 months ago by Jay Civelli

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 50913 TranslateManagerTest.NormalTranslate fails on Linux TranslateInfoBarDelegate2 were leaked. (Yikes!) This revealed that the NormalTranslate unit-test was incorrect (it was not testing that changing the source or target language from the after translate infobar causes a translation). This also revealed that returning reference string in the delegate is not a brilliant idea as when we switch infobars, the new infobar might be using a string from the old infobar that might have been deleted. BUG=None TEST=Linux heap check bot should be green. Review URL: http://codereview.chromium.org/2822032 TBR=jcivelli@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50914

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -42 lines)			Patch
M	chrome/browser/translate/translate_infobar_delegate2.h	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/translate/translate_infobar_delegate2.cc	View	3 chunks	+6 lines, -10 lines	0 comments	Download
M	chrome/browser/translate/translate_manager2_unittest.cc	View	1 chunk	+7 lines, -26 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages