Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2410)

Unified Diff: chrome/browser/translate/translate_infobar_delegate2.h

Issue 2879004: Revert 50913... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/translate/translate_infobar_delegate2.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_infobar_delegate2.h
===================================================================
--- chrome/browser/translate/translate_infobar_delegate2.h (revision 50913)
+++ chrome/browser/translate/translate_infobar_delegate2.h (working copy)
@@ -49,10 +49,10 @@
int GetLanguageCount() const;
// Returns the ISO code for the language at |index|.
- std::string GetLanguageCodeAt(int index) const;
+ const std::string& GetLanguageCodeAt(int index) const;
// Returns the displayable name for the language at |index|.
- string16 GetLanguageDisplayableNameAt(int index) const;
+ const string16& GetLanguageDisplayableNameAt(int index) const;
TabContents* tab_contents() const { return tab_contents_; }
@@ -62,8 +62,8 @@
int target_language_index() const { return target_language_index_; }
// Convenience methods.
- std::string GetOriginalLanguageCode() const;
- std::string GetTargetLanguageCode() const;
+ const std::string& GetOriginalLanguageCode() const;
+ const std::string& GetTargetLanguageCode() const;
// Called by the InfoBar to notify that the original/target language has
// changed and is now the language at |language_index|.
@@ -89,8 +89,7 @@
// InfoBarDelegate implementation:
virtual InfoBar* CreateInfoBar();
- virtual void InfoBarDismissed();
- virtual void InfoBarClosed();
+ void InfoBarDismissed();
virtual SkBitmap* GetIcon() const;
virtual InfoBarDelegate::Type GetInfoBarType();
virtual TranslateInfoBarDelegate2* AsTranslateInfoBarDelegate2() {
« no previous file with comments | « no previous file | chrome/browser/translate/translate_infobar_delegate2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698