Issue 2879002: Reapply r50859 with chromeos fixes.

Issue 2879002: Reapply r50859 with chromeos fixes. (Closed)

Created:
10 years, 6 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Reapply r50859 with chromeos fixes. GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items. Adds special menu item types that allow shoving buttons into them, along with tracking which button is selected. We now are halfway to the mocks that the chrome-ui-leads sent out. Review URL: http://codereview.chromium.org/2800015 BUG=45757 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50896

Patch Set 1 #

Patch Set 2 : add explicit menus:: to chromeos #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1088 lines, -32 lines)			Patch
M	app/app_base.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	app/menus/button_menu_item_model.h	View		1 chunk	+103 lines, -0 lines	0 comments	Download
A	app/menus/button_menu_item_model.cc	View		1 chunk	+65 lines, -0 lines	0 comments	Download
M	app/menus/menu_model.h	View		3 chunks	+5 lines, -0 lines	0 comments	Download
M	app/menus/simple_menu_model.h	View	1	4 chunks	+7 lines, -0 lines	0 comments	Download
M	app/menus/simple_menu_model.cc	View		9 chunks	+23 lines, -10 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/back_forward_menu_model.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/back_forward_menu_model.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/clock_menu_button.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/feedback_menu_button.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/language_menu_button.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/language_menu_button.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/power_menu_button.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/gtk_custom_menu.h	View		1 chunk	+53 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/gtk_custom_menu.cc	View		1 chunk	+144 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/gtk_custom_menu_item.h	View		1 chunk	+118 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/gtk_custom_menu_item.cc	View		1 chunk	+282 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/gtk_util.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/gtk_util.cc	View		3 chunks	+17 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/menu_gtk.h	View		4 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/menu_gtk.cc	View		8 chunks	+84 lines, -7 lines	0 comments	Download
M	chrome/browser/gtk/notifications/notification_options_menu_model.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/gtk/notifications/notification_options_menu_model.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/wrench_menu_model.h	View		3 chunks	+40 lines, -12 lines	0 comments	Download
M	chrome/browser/wrench_menu_model.cc	View		4 chunks	+86 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+8 lines, -0 lines	0 comments	Download