Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm

Issue 2878075: Introduce a resource identifier for content settings. (Closed)
Patch Set: updates Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/content_exceptions_table_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm
diff --git a/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm b/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm
index 2c842b5c69eb23dbb475e2a0243dbaf7b18d4b47..3ec1944b688d2b9af186a3e7e25fe74aba55603c 100644
--- a/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm
+++ b/chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm
@@ -112,6 +112,7 @@ TEST_F(ContentExceptionsWindowControllerTest, AddRemove) {
ClickAdd(controller);
settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
+ "",
&settings);
EXPECT_EQ(0u, settings.size());
@@ -121,6 +122,7 @@ TEST_F(ContentExceptionsWindowControllerTest, AddRemove) {
[controller close];
settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
+ "",
&settings);
EXPECT_EQ(0u, settings.size());
}
@@ -138,6 +140,7 @@ TEST_F(ContentExceptionsWindowControllerTest, AddRemoveAll) {
HostContentSettingsMap::SettingsForOneType settings;
settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
+ "",
&settings);
EXPECT_EQ(0u, settings.size());
}
@@ -154,6 +157,7 @@ TEST_F(ContentExceptionsWindowControllerTest, Add) {
HostContentSettingsMap::SettingsForOneType settings;
settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
+ "",
&settings);
EXPECT_EQ(1u, settings.size());
EXPECT_EQ(HostContentSettingsMap::Pattern("addedhost"), settings[0].first);
@@ -169,6 +173,7 @@ TEST_F(ContentExceptionsWindowControllerTest, AddEscDoesNotAdd) {
HostContentSettingsMap::SettingsForOneType settings;
settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
+ "",
&settings);
EXPECT_EQ(0u, settings.size());
EXPECT_FALSE([controller editingNewException]);
@@ -191,6 +196,7 @@ TEST_F(ContentExceptionsWindowControllerTest, AddEditAddAdd) {
HostContentSettingsMap::SettingsForOneType settings;
settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
+ "",
&settings);
EXPECT_EQ(0u, settings.size());
}
@@ -198,6 +204,7 @@ TEST_F(ContentExceptionsWindowControllerTest, AddEditAddAdd) {
TEST_F(ContentExceptionsWindowControllerTest, AddExistingEditAdd) {
settingsMap_->SetContentSetting(HostContentSettingsMap::Pattern("myhost"),
CONTENT_SETTINGS_TYPE_PLUGINS,
+ "",
CONTENT_SETTING_BLOCK);
ContentExceptionsWindowController* controller =
@@ -213,6 +220,7 @@ TEST_F(ContentExceptionsWindowControllerTest, AddExistingEditAdd) {
HostContentSettingsMap::SettingsForOneType settings;
settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
+ "",
&settings);
EXPECT_EQ(1u, settings.size());
}
@@ -220,6 +228,7 @@ TEST_F(ContentExceptionsWindowControllerTest, AddExistingEditAdd) {
TEST_F(ContentExceptionsWindowControllerTest, AddExistingDoesNotOverwrite) {
settingsMap_->SetContentSetting(HostContentSettingsMap::Pattern("myhost"),
CONTENT_SETTINGS_TYPE_COOKIES,
+ "",
CONTENT_SETTING_SESSION_ONLY);
ContentExceptionsWindowController* controller =
@@ -233,6 +242,7 @@ TEST_F(ContentExceptionsWindowControllerTest, AddExistingDoesNotOverwrite) {
HostContentSettingsMap::SettingsForOneType settings;
settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_COOKIES,
+ "",
&settings);
EXPECT_EQ(1u, settings.size());
EXPECT_EQ(CONTENT_SETTING_SESSION_ONLY, settings[0].second);
« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/content_exceptions_table_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698