Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm

Issue 2878075: Introduce a resource identifier for content settings. (Closed)
Patch Set: updates Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/cocoa/content_exceptions_window_controller.h" 5 #import "chrome/browser/cocoa/content_exceptions_window_controller.h"
6 6
7 #import <Cocoa/Cocoa.h> 7 #import <Cocoa/Cocoa.h>
8 8
9 #import "base/scoped_nsobject.h" 9 #import "base/scoped_nsobject.h"
10 #include "base/ref_counted.h" 10 #include "base/ref_counted.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 105
106 // Regression test for http://crbug.com/37137 106 // Regression test for http://crbug.com/37137
107 TEST_F(ContentExceptionsWindowControllerTest, AddRemove) { 107 TEST_F(ContentExceptionsWindowControllerTest, AddRemove) {
108 ContentExceptionsWindowController* controller = 108 ContentExceptionsWindowController* controller =
109 GetController(CONTENT_SETTINGS_TYPE_PLUGINS); 109 GetController(CONTENT_SETTINGS_TYPE_PLUGINS);
110 110
111 HostContentSettingsMap::SettingsForOneType settings; 111 HostContentSettingsMap::SettingsForOneType settings;
112 112
113 ClickAdd(controller); 113 ClickAdd(controller);
114 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS, 114 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
115 "",
115 &settings); 116 &settings);
116 EXPECT_EQ(0u, settings.size()); 117 EXPECT_EQ(0u, settings.size());
117 118
118 ClickRemove(controller); 119 ClickRemove(controller);
119 120
120 EXPECT_FALSE([controller editingNewException]); 121 EXPECT_FALSE([controller editingNewException]);
121 [controller close]; 122 [controller close];
122 123
123 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS, 124 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
125 "",
124 &settings); 126 &settings);
125 EXPECT_EQ(0u, settings.size()); 127 EXPECT_EQ(0u, settings.size());
126 } 128 }
127 129
128 // Regression test for http://crbug.com/37137 130 // Regression test for http://crbug.com/37137
129 TEST_F(ContentExceptionsWindowControllerTest, AddRemoveAll) { 131 TEST_F(ContentExceptionsWindowControllerTest, AddRemoveAll) {
130 ContentExceptionsWindowController* controller = 132 ContentExceptionsWindowController* controller =
131 GetController(CONTENT_SETTINGS_TYPE_PLUGINS); 133 GetController(CONTENT_SETTINGS_TYPE_PLUGINS);
132 134
133 ClickAdd(controller); 135 ClickAdd(controller);
134 ClickRemoveAll(controller); 136 ClickRemoveAll(controller);
135 137
136 EXPECT_FALSE([controller editingNewException]); 138 EXPECT_FALSE([controller editingNewException]);
137 [controller close]; 139 [controller close];
138 140
139 HostContentSettingsMap::SettingsForOneType settings; 141 HostContentSettingsMap::SettingsForOneType settings;
140 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS, 142 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
143 "",
141 &settings); 144 &settings);
142 EXPECT_EQ(0u, settings.size()); 145 EXPECT_EQ(0u, settings.size());
143 } 146 }
144 147
145 TEST_F(ContentExceptionsWindowControllerTest, Add) { 148 TEST_F(ContentExceptionsWindowControllerTest, Add) {
146 ContentExceptionsWindowController* controller = 149 ContentExceptionsWindowController* controller =
147 GetController(CONTENT_SETTINGS_TYPE_PLUGINS); 150 GetController(CONTENT_SETTINGS_TYPE_PLUGINS);
148 151
149 ClickAdd(controller); 152 ClickAdd(controller);
150 EnterText(@"addedhost\n"); 153 EnterText(@"addedhost\n");
151 154
152 EXPECT_FALSE([controller editingNewException]); 155 EXPECT_FALSE([controller editingNewException]);
153 [controller close]; 156 [controller close];
154 157
155 HostContentSettingsMap::SettingsForOneType settings; 158 HostContentSettingsMap::SettingsForOneType settings;
156 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS, 159 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
160 "",
157 &settings); 161 &settings);
158 EXPECT_EQ(1u, settings.size()); 162 EXPECT_EQ(1u, settings.size());
159 EXPECT_EQ(HostContentSettingsMap::Pattern("addedhost"), settings[0].first); 163 EXPECT_EQ(HostContentSettingsMap::Pattern("addedhost"), settings[0].first);
160 } 164 }
161 165
162 TEST_F(ContentExceptionsWindowControllerTest, AddEscDoesNotAdd) { 166 TEST_F(ContentExceptionsWindowControllerTest, AddEscDoesNotAdd) {
163 ContentExceptionsWindowController* controller = 167 ContentExceptionsWindowController* controller =
164 GetController(CONTENT_SETTINGS_TYPE_PLUGINS); 168 GetController(CONTENT_SETTINGS_TYPE_PLUGINS);
165 169
166 ClickAdd(controller); 170 ClickAdd(controller);
167 EnterText(@"addedhost"); // but do not press enter 171 EnterText(@"addedhost"); // but do not press enter
168 HitEscape(controller); 172 HitEscape(controller);
169 173
170 HostContentSettingsMap::SettingsForOneType settings; 174 HostContentSettingsMap::SettingsForOneType settings;
171 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS, 175 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
176 "",
172 &settings); 177 &settings);
173 EXPECT_EQ(0u, settings.size()); 178 EXPECT_EQ(0u, settings.size());
174 EXPECT_FALSE([controller editingNewException]); 179 EXPECT_FALSE([controller editingNewException]);
175 180
176 [controller close]; 181 [controller close];
177 } 182 }
178 183
179 // Regression test for http://crbug.com/37208 184 // Regression test for http://crbug.com/37208
180 TEST_F(ContentExceptionsWindowControllerTest, AddEditAddAdd) { 185 TEST_F(ContentExceptionsWindowControllerTest, AddEditAddAdd) {
181 ContentExceptionsWindowController* controller = 186 ContentExceptionsWindowController* controller =
182 GetController(CONTENT_SETTINGS_TYPE_PLUGINS); 187 GetController(CONTENT_SETTINGS_TYPE_PLUGINS);
183 188
184 ClickAdd(controller); 189 ClickAdd(controller);
185 EnterText(@"testtesttest"); // but do not press enter 190 EnterText(@"testtesttest"); // but do not press enter
186 ClickAdd(controller); 191 ClickAdd(controller);
187 ClickAdd(controller); 192 ClickAdd(controller);
188 193
189 EXPECT_TRUE([controller editingNewException]); 194 EXPECT_TRUE([controller editingNewException]);
190 [controller close]; 195 [controller close];
191 196
192 HostContentSettingsMap::SettingsForOneType settings; 197 HostContentSettingsMap::SettingsForOneType settings;
193 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS, 198 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
199 "",
194 &settings); 200 &settings);
195 EXPECT_EQ(0u, settings.size()); 201 EXPECT_EQ(0u, settings.size());
196 } 202 }
197 203
198 TEST_F(ContentExceptionsWindowControllerTest, AddExistingEditAdd) { 204 TEST_F(ContentExceptionsWindowControllerTest, AddExistingEditAdd) {
199 settingsMap_->SetContentSetting(HostContentSettingsMap::Pattern("myhost"), 205 settingsMap_->SetContentSetting(HostContentSettingsMap::Pattern("myhost"),
200 CONTENT_SETTINGS_TYPE_PLUGINS, 206 CONTENT_SETTINGS_TYPE_PLUGINS,
207 "",
201 CONTENT_SETTING_BLOCK); 208 CONTENT_SETTING_BLOCK);
202 209
203 ContentExceptionsWindowController* controller = 210 ContentExceptionsWindowController* controller =
204 GetController(CONTENT_SETTINGS_TYPE_PLUGINS); 211 GetController(CONTENT_SETTINGS_TYPE_PLUGINS);
205 212
206 ClickAdd(controller); 213 ClickAdd(controller);
207 EnterText(@"myhost"); // but do not press enter 214 EnterText(@"myhost"); // but do not press enter
208 ClickAdd(controller); 215 ClickAdd(controller);
209 216
210 EXPECT_TRUE([controller editingNewException]); 217 EXPECT_TRUE([controller editingNewException]);
211 [controller close]; 218 [controller close];
212 219
213 220
214 HostContentSettingsMap::SettingsForOneType settings; 221 HostContentSettingsMap::SettingsForOneType settings;
215 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS, 222 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
223 "",
216 &settings); 224 &settings);
217 EXPECT_EQ(1u, settings.size()); 225 EXPECT_EQ(1u, settings.size());
218 } 226 }
219 227
220 TEST_F(ContentExceptionsWindowControllerTest, AddExistingDoesNotOverwrite) { 228 TEST_F(ContentExceptionsWindowControllerTest, AddExistingDoesNotOverwrite) {
221 settingsMap_->SetContentSetting(HostContentSettingsMap::Pattern("myhost"), 229 settingsMap_->SetContentSetting(HostContentSettingsMap::Pattern("myhost"),
222 CONTENT_SETTINGS_TYPE_COOKIES, 230 CONTENT_SETTINGS_TYPE_COOKIES,
231 "",
223 CONTENT_SETTING_SESSION_ONLY); 232 CONTENT_SETTING_SESSION_ONLY);
224 233
225 ContentExceptionsWindowController* controller = 234 ContentExceptionsWindowController* controller =
226 GetController(CONTENT_SETTINGS_TYPE_COOKIES); 235 GetController(CONTENT_SETTINGS_TYPE_COOKIES);
227 236
228 ClickAdd(controller); 237 ClickAdd(controller);
229 EnterText(@"myhost\n"); 238 EnterText(@"myhost\n");
230 239
231 EXPECT_FALSE([controller editingNewException]); 240 EXPECT_FALSE([controller editingNewException]);
232 [controller close]; 241 [controller close];
233 242
234 HostContentSettingsMap::SettingsForOneType settings; 243 HostContentSettingsMap::SettingsForOneType settings;
235 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_COOKIES, 244 settingsMap_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_COOKIES,
245 "",
236 &settings); 246 &settings);
237 EXPECT_EQ(1u, settings.size()); 247 EXPECT_EQ(1u, settings.size());
238 EXPECT_EQ(CONTENT_SETTING_SESSION_ONLY, settings[0].second); 248 EXPECT_EQ(CONTENT_SETTING_SESSION_ONLY, settings[0].second);
239 } 249 }
240 250
241 251
242 } // namespace 252 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/content_exceptions_table_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698