Introduce a resource identifier for content settings.

Introduce a resource identifier for content settings.

This will allow for having per plugin content settings, i.e. the content settings type would be plugin and the resource identifier would be to concrete plugin that is about to be loaded.

BUG=39252
TEST=unit_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55213

[jochen (gone - plz use gerrit), 2010-08-03 15:55:26]

work in process.

That patch so far only changes the interface and adopts all calling sites on
linux.

[Bernhard Bauer, 2010-08-03 17:06:51]

http://codereview.chromium.org/2878075/diff/1/11
File chrome/browser/host_content_settings_map.cc (right):

http://codereview.chromium.org/2878075/diff/1/11#newcode426
chrome/browser/host_content_settings_map.cc:426:
SetContentSetting(Pattern::FromURL(url), content_type, "", setting);
Even if you're currently only changing the interface, you could still pass
|resource_identifier| through here.

http://codereview.chromium.org/2878075/diff/1/12
File chrome/browser/host_content_settings_map.h (right):

http://codereview.chromium.org/2878075/diff/1/12#newcode82
chrome/browser/host_content_settings_map.h:82:
resource_identifier_(resource_identifier) {}
Do we actually need all these constructors? IIRC, the style guidelines say that
overloading constructors to simulate default parameters is not allowed anyway.

[jochen (gone - plz use gerrit), 2010-08-06 09:50:18]

please review.

[Bernhard Bauer, 2010-08-06 10:57:25]

LGTM

http://codereview.chromium.org/2878075/diff/5002/15012
File chrome/browser/host_content_settings_map.cc (right):

http://codereview.chromium.org/2878075/diff/5002/15012#newcode45
chrome/browser/host_content_settings_map.cc:45: // The prefernce keys where
resource identifiers are stored for
Nit: "preference"