Issue 2877002: Show tooltips only for users with identical display names....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2877002: Show tooltips only for users with identical display names.... (Closed)

Created:
10 years, 6 months ago by whywhat

Modified:
9 years, 7 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Show tooltips only for users with identical display names. Tooltip text is changed from email to "<display name> (<domain>)". BUG=cros:2318 TEST=Verify that tooltips are shown only for users with equal display names. Tooltips show display name and domain. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51129

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -13 lines)			Patch
	M	chrome/browser/chromeos/login/existing_user_controller.cc	View	1 2 3	2 chunks	+10 lines, -12 lines	0 comments	Download
	M	chrome/browser/chromeos/login/user_controller.cc	View	1 2 3	2 chunks	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

LGTM http://codereview.chromium.org/2877002/diff/1/2 File chrome/browser/chromeos/login/existing_user_controller.cc (left): http://codereview.chromium.org/2877002/diff/1/2#oldcode282 chrome/browser/chromeos/login/existing_user_controller.cc:282: void ExistingUserController::AppendStartUrlToCmdline() { Merge failed (+2 chunks below)

10 years, 6 months ago (2010-06-25 14:17:04 UTC) #2

whywhat

10 years, 6 months ago (2010-06-25 14:35:27 UTC) #3

http://codereview.chromium.org/2877002/diff/1/2
File chrome/browser/chromeos/login/existing_user_controller.cc (left):

http://codereview.chromium.org/2877002/diff/1/2#oldcode282
chrome/browser/chromeos/login/existing_user_controller.cc:282: void
ExistingUserController::AppendStartUrlToCmdline() {
On 2010/06/25 14:17:04, Nikita Kostylev wrote:
> Merge failed (+2 chunks below)

Done.

Expand Messages | Collapse Messages