Show tooltips only for users with identical display names....

chrome/browser/chromeos/login/existing_user_controller.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/existing_user_controller.h"
 
 #include <algorithm>
 #include <functional>
-#include <set>
+#include <map>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/message_loop.h"
 #include "base/stl_util-inl.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_thread.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/cros/login_library.h"
@@ skipping 31 matching lines @@
 const char kCaptchaTokenParam[] = "CaptchaToken=";
 const char kParamSuffix[] = "\n";
 
 // URL prefix for CAPTCHA image.
 const char kCaptchaUrlPrefix[] = "http://www.google.com/accounts/";
 
 // Checks if display names are unique. If there are duplicates, enables
 // tooltips with full emails to let users distinguish their accounts.
 // Otherwise, disables the tooltips.
 void EnableTooltipsIfNeeded(const std::vector<UserController*>& controllers) {
-  bool show_name_tooltips = false;
-  std::set<std::string> visible_display_names;
-  for (size_t i = 0; i < controllers.size(); ++i) {
+  std::map<std::string, int> visible_display_names;
+  for (size_t i = 0; i + 1 < controllers.size(); ++i) {
     const std::string& display_name =
         controllers[i]->user().GetDisplayName();
-    if (visible_display_names.count(display_name) > 0) {
-      show_name_tooltips = true;
-      break;
-    }
-    visible_display_names.insert(display_name);
+    ++visible_display_names[display_name];
   }
-  for (size_t i = 0; i < controllers.size(); ++i)
-    if (!controllers[i]->is_guest())
-      controllers[i]->EnableNameTooltip(show_name_tooltips);
+  for (size_t i = 0; i + 1 < controllers.size(); ++i) {
+    const std::string& display_name =
+        controllers[i]->user().GetDisplayName();
+    bool show_tooltip = visible_display_names[display_name] > 1;
+    controllers[i]->EnableNameTooltip(show_tooltip);
+  }
 }
 
 }  // namespace
 
 ExistingUserController::ExistingUserController(
     const std::vector<UserManager::User>& users,
     const gfx::Rect& background_bounds)
     : background_bounds_(background_bounds),
       background_window_(NULL),
       background_view_(NULL),
@@ skipping 253 matching lines @@
 void ExistingUserController::OnOffTheRecordLoginSuccess() {
   AppendStartUrlToCmdline();
   LoginUtils::Get()->CompleteOffTheRecordLogin();
 }
 
 void ExistingUserController::OnCaptchaEntered(const std::string& captcha) {
   login_captcha_ = captcha;
 }
 
 }  // namespace chromeos