Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2876040: Fix a regression with satisfying range requests out of the appcache and add a... (Closed)

Created:
10 years, 5 months ago by michaeln
Modified:
9 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, michaeln, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix a regression with satisfying range requests out of the appcache and add a unit_test. TEST=AppCacheURLRequestJobTest.DeliverPartialResponse BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51585

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -6 lines) Patch
M webkit/appcache/appcache_url_request_job.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_url_request_job.cc View 1 2 chunks +11 lines, -5 lines 0 comments Download
M webkit/appcache/appcache_url_request_job_unittest.cc View 1 2 chunks +67 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
michaeln
please review
10 years, 5 months ago (2010-07-02 19:42:06 UTC) #1
michaeln
hi eric, can you take a look at this cl?
10 years, 5 months ago (2010-07-02 21:00:59 UTC) #2
eroman
10 years, 5 months ago (2010-07-02 22:51:54 UTC) #3
LGTM.

D'oh!

Powered by Google App Engine
This is Rietveld 408576698