Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Side by Side Diff: webkit/appcache/appcache_url_request_job.h

Issue 2876040: Fix a regression with satisfying range requests out of the appcache and add a... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | webkit/appcache/appcache_url_request_job.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_APPCACHE_APPCACHE_URL_REQUEST_JOB_H_ 5 #ifndef WEBKIT_APPCACHE_APPCACHE_URL_REQUEST_JOB_H_
6 #define WEBKIT_APPCACHE_APPCACHE_URL_REQUEST_JOB_H_ 6 #define WEBKIT_APPCACHE_APPCACHE_URL_REQUEST_JOB_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "net/http/http_byte_range.h" 10 #include "net/http/http_byte_range.h"
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 101
102 // URLRequestJob methods, see url_request_job.h for doc comments 102 // URLRequestJob methods, see url_request_job.h for doc comments
103 virtual void Start(); 103 virtual void Start();
104 virtual net::LoadState GetLoadState() const; 104 virtual net::LoadState GetLoadState() const;
105 virtual bool GetCharset(std::string* charset); 105 virtual bool GetCharset(std::string* charset);
106 virtual void GetResponseInfo(net::HttpResponseInfo* info); 106 virtual void GetResponseInfo(net::HttpResponseInfo* info);
107 virtual bool ReadRawData(net::IOBuffer* buf, int buf_size, int *bytes_read); 107 virtual bool ReadRawData(net::IOBuffer* buf, int buf_size, int *bytes_read);
108 108
109 // Sets extra request headers for Job types that support request headers. 109 // Sets extra request headers for Job types that support request headers.
110 // This is how we get informed of range-requests. 110 // This is how we get informed of range-requests.
111 virtual void SetExtraRequestHeaders(const std::string& headers); 111 virtual void SetExtraRequestHeaders(const net::HttpRequestHeaders& headers);
112 112
113 // TODO(michaeln): does this apply to our cached responses? 113 // TODO(michaeln): does this apply to our cached responses?
114 // The payload we store should have been fully decoded prior to 114 // The payload we store should have been fully decoded prior to
115 // us storing it. Maybe we should strip the content-encoding headers 115 // us storing it. Maybe we should strip the content-encoding headers
116 // when writing the response to the cache. 116 // when writing the response to the cache.
117 // virtual bool GetContentEncodings( 117 // virtual bool GetContentEncodings(
118 // std::vector<Filter::FilterType>* encoding_types); 118 // std::vector<Filter::FilterType>* encoding_types);
119 119
120 // FilterContext methods 120 // FilterContext methods
121 virtual bool GetMimeType(std::string* mime_type) const; 121 virtual bool GetMimeType(std::string* mime_type) const;
(...skipping 13 matching lines...) Expand all
135 net::HttpByteRange range_requested_; 135 net::HttpByteRange range_requested_;
136 scoped_ptr<net::HttpResponseInfo> range_response_info_; 136 scoped_ptr<net::HttpResponseInfo> range_response_info_;
137 scoped_ptr<AppCacheResponseReader> reader_; 137 scoped_ptr<AppCacheResponseReader> reader_;
138 net::CompletionCallbackImpl<AppCacheURLRequestJob> read_callback_; 138 net::CompletionCallbackImpl<AppCacheURLRequestJob> read_callback_;
139 }; 139 };
140 140
141 } // namespace appcache 141 } // namespace appcache
142 142
143 #endif // WEBKIT_APPCACHE_APPCACHE_REQUEST_HANDLER_H_ 143 #endif // WEBKIT_APPCACHE_APPCACHE_REQUEST_HANDLER_H_
144 144
OLDNEW
« no previous file with comments | « no previous file | webkit/appcache/appcache_url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698