Refactor the wait code in ProfileSyncServiceTestHarness.

Refactor the wait code in ProfileSyncServiceTestHarness.

The sync integration tests use the methods defined in the
ProfileSyncServiceTestHarness class to coordinate various sync related
activities carried out by each test case.

The sync codebase has ungergone significant change since this class was
originally implemented. In this checkin, the class has been refactored
to match the sync codebase. The pass rate for integration tests went up
from ~20% to 90+% with this checkin.

BUG=44957
TEST=sync_integration_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51500

[Raghu Simha, 2010-07-01 23:47:40]

This now has the changes we talked about today, and is ready for review.

[tim (not reviewing), 2010-07-01 23:50:34]

LGTM

http://codereview.chromium.org/2876029/diff/3001/4001
File chrome/test/live_sync/live_sync_test.h (right):

http://codereview.chromium.org/2876029/diff/3001/4001#newcode59
chrome/test/live_sync/live_sync_test.h:59:
InProcessBrowserTest::SetInitialTimeoutInMS(300000);
nit - please make this a constant at the top of the file.

[Raghu Simha, 2010-07-02 00:06:15]

http://codereview.chromium.org/2876029/diff/3001/4001
File chrome/test/live_sync/live_sync_test.h (right):

http://codereview.chromium.org/2876029/diff/3001/4001#newcode59
chrome/test/live_sync/live_sync_test.h:59:
InProcessBrowserTest::SetInitialTimeoutInMS(300000);
On 2010/07/01 23:50:34, timsteele wrote:
> nit - please make this a constant at the top of the file.

Done.