Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7090)

Unified Diff: chrome/test/live_sync/profile_sync_service_test_harness.h

Issue 2876029: Refactor the wait code in ProfileSyncServiceTestHarness. (Closed)
Patch Set: Making test timeout a const int. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/live_sync/live_sync_test.h ('k') | chrome/test/live_sync/profile_sync_service_test_harness.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/live_sync/profile_sync_service_test_harness.h
diff --git a/chrome/test/live_sync/profile_sync_service_test_harness.h b/chrome/test/live_sync/profile_sync_service_test_harness.h
index 7ebf47793bbb94c67a8855cb41ca5fa0390c62db..bcce77f1af9ad5edee4a42d52c3b67a7c862e094 100644
--- a/chrome/test/live_sync/profile_sync_service_test_harness.h
+++ b/chrome/test/live_sync/profile_sync_service_test_harness.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -54,11 +54,16 @@ class ProfileSyncServiceTestHarness : public ProfileSyncServiceObserver {
friend class StateChangeTimeoutEvent;
enum WaitState {
- WAITING_FOR_INITIAL_CALLBACK = 0,
- WAITING_FOR_READY_TO_PROCESS_CHANGES,
+ // The sync client awaits the OnAuthError() callback.
+ WAITING_FOR_ON_AUTH_ERROR = 0,
+ // The sync client is waiting for notifications_enabled to become true.
+ WAITING_FOR_NOTIFICATIONS_ENABLED,
+ // The sync client is waiting for an ongoing sync cycle to complete.
WAITING_FOR_SYNC_TO_FINISH,
+ // The sync client anticipates incoming updates leading to a new sync cycle.
WAITING_FOR_UPDATES,
- WAITING_FOR_NOTHING,
+ // The sync client is fully synced and there are no pending updates.
+ FULLY_SYNCED,
NUMBER_OF_STATES
};
« no previous file with comments | « chrome/test/live_sync/live_sync_test.h ('k') | chrome/test/live_sync/profile_sync_service_test_harness.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698