Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2876008: Make reload accelerators more consistent across platforms. (Closed)

Created:
10 years, 6 months ago by Daniel Erat
Modified:
9 years, 7 months ago
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Make reload accelerators more consistent across platforms. On Windows and Linux (both Views and GTK+), this makes Ctrl-R, F5, and regular clicks on the reload button do regular reloads, while Ctrl-Shift-R, Shift-F5, Control-F5, and holding Shift or Control while clicking the button all bypass the cache. It does the same for the reload button on Mac, but I'm not modifying any Mac keyboard shortcuts in this change (it looks like Command-Shift-R already bypasses the cache). I've updated http://crbug.com/38356 to mention that when the F5 shortcut is added to Mac, the cache-bypassing modifiers should also be supported. BUG=47383 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55175

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M chrome/browser/cocoa/browser_window_controller.mm View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/gtk/accelerators_gtk.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/reload_button_gtk.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/views/reload_button.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
I've been unable to find where the Command-R accelerator is being defined for Mac -- ...
10 years, 6 months ago (2010-06-24 23:09:57 UTC) #1
Peter Kasting
LGTM, but the description isn't really accurate until you handle the Mac accelerator issue. I ...
10 years, 6 months ago (2010-06-24 23:12:56 UTC) #2
Peter Kasting
Daniel, this seems like it never landed. I think it can land as-is and then ...
10 years, 5 months ago (2010-07-27 19:39:46 UTC) #3
Daniel Erat
10 years, 5 months ago (2010-07-27 19:50:23 UTC) #4
On 2010/07/27 19:39:46, Peter Kasting wrote:
> Daniel, this seems like it never landed.  I think it can land as-is and then
> there remains a bit of followup work on Mac, right?

Sorry, I should've updated this.  It looks like someone fixed part of this in a
separate change, making this change seem less useful post-merge (it now just
adds support for Ctrl-F5 on GTK, and for Ctrl-clicking the Reload button on Mac
and GTK).  jrg asked me to try it out on a Mac, which I don't have any idea how
to do and haven't had time to figure out, but if you'd like to do so and then
check it in, please feel free.

Powered by Google App Engine
This is Rietveld 408576698