Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2873029: Fix a crasher with the translate infobar.... (Closed)

Created:
10 years, 5 months ago by Jay Civelli
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Fix a crasher with the translate infobar. Turns out calling Close() from an infobar class to close it is a bad idea as it only removes its associated view so it is not displayed, but the tab contents still belives it is showing. RemoveInfoBar() should be called instead. I made the InfobarContainer methods private and made InfobarContainer a friend to prevent other people from running into the same problem. BUG=47669 TEST=Open a www.google.de In the translate infobar, click Nope. Navigate away from the page, it should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51131

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -53 lines) Patch
M chrome/browser/views/infobars/before_translate_infobar.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/infobars/infobars.h View 1 2 chunks +17 lines, -15 lines 0 comments Download
M chrome/browser/views/infobars/infobars.cc View 2 chunks +37 lines, -37 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jay Civelli
10 years, 5 months ago (2010-06-28 23:55:24 UTC) #1
sky
10 years, 5 months ago (2010-06-29 00:20:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698