Issue 2873002: AutoFill Mac UI : Validation, CVC Removal, Credit Card year list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2873002: AutoFill Mac UI : Validation, CVC Removal, Credit Card year list. (Closed)

Created:
10 years, 6 months ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

AutoFill Mac UI : Validation, CVC Removal, Credit Card year list. Implements changes based on review feedback with Jeff. Validation icons should not appear in phone and fax input fields until text is input. Credit card expiration date year dropdown should list 10 years at most. CVC input fields are removed. Nib changes to AutoFillCreditCardSheet.xib removes the CVC entry, associated label, and resize / relayout dialog to account for removal. BUG=46681, 46635, 46634 TEST=Manual testing, AutoFillDialogControllerTest.*, AutoFillAddressViewControllerTest.*, AutoFillCreditCardViewControllerTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50008

Patch Set 1 #

Patch Set 2 : Sync with ToT #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -139 lines)			Patch
M	chrome/app/nibs/AutoFillCreditCardSheet.xib	View	19 chunks	+33 lines, -122 lines	0 comments	Download
M	chrome/browser/autofill/autofill_credit_card_model_mac.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/autofill/autofill_credit_card_model_mac.mm	View	4 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/autofill/autofill_credit_card_model_mac_unittest.mm	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autofill/autofill_dialog_controller_mac.mm	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm	View	2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages