AutoFill Mac UI : Validation, CVC Removal, Credit Card year list.

chrome/browser/autofill/autofill_dialog_controller_mac.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/autofill/autofill_dialog_controller_mac.h"
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/mac_util.h"
 #include "base/sys_string_conversions.h"
 #import "chrome/browser/autofill/autofill_address_model_mac.h"
@@ skipping 746 matching lines @@
   return [NSImage class];
 }
 
 + (BOOL)allowsReverseTransformation {
   return NO;
 }
 
 - (id)transformedValue:(id)string {
   NSImage* image = nil;
   ResourceBundle& rb = ResourceBundle::GetSharedInstance();
+
+  // We display no validation icon when input has not yet been entered.
+  if (string == nil || [string length] == 0)
+    return nil;
+
+  // If we have input then display alert icon if we have an invalid number.
   if (string != nil && [string length] != 0) {
     // TODO(dhollowa): Using SetInfo() call to validate phone number.  Should
     // have explicit validation method.  More robust validation is needed as
     // well eventually.
     AutoFillProfile profile(string16(), 0);
     profile.SetInfo(AutoFillType(PHONE_HOME_WHOLE_NUMBER),
                     base::SysNSStringToUTF16(string));
     if (profile.GetFieldText(AutoFillType(PHONE_HOME_WHOLE_NUMBER)).empty()) {
       image = rb.GetNSImageNamed(IDR_INPUT_ALERT);
       DCHECK(image);
       return image;
     }
   }
 
+  // No alert icon, so must be valid input.
   if (!image) {
     image = rb.GetNSImageNamed(IDR_INPUT_GOOD);
     DCHECK(image);
     return image;
   }
 
   return nil;
 }
 
 @end