Issue 2872024: Fixed invalid read in ExtensionsServiceTest.ReloadExtensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2872024: Fixed invalid read in ExtensionsServiceTest.ReloadExtensions. (Closed)

Created:
10 years, 5 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
rafaelw

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Fixed invalid read in ExtensionsServiceTest.ReloadExtensions. BUG=47843, 47863 TEST=unittests, valgrind Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51215 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52461 Note that the latter commit was mistakenly associated with this code review: it should have been associated with http://codereview.chromium.org/2854044/show .

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/extensions/extensions_service_unittest.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rafaelw

sorry i didn't think of this when i lgtm'd. you'll probably want to undo the ...

10 years, 5 months ago (2010-06-30 02:45:42 UTC) #3

akalin (wrong akalin)

10 years, 5 months ago (2010-06-30 02:52:39 UTC) #4

I have a separate CL out for that: http://codereview.chromium.org/2867033/show

On Tue, Jun 29, 2010 at 7:45 PM,  <rafaelw@chromium.org> wrote:
> sorry i didn't think of this when i lgtm'd. you'll probably want to undo the
> suppressions:
>
> http://codereview.chromium.org/2872024/show
>
> http://codereview.chromium.org/2810039
>
> http://codereview.chromium.org/2872024/show
>



-- 
Frederick Akalin
Software Engineer

Expand Messages | Collapse Messages