Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1810)

Unified Diff: chrome/browser/extensions/extensions_service_unittest.cc

Issue 2872024: Fixed invalid read in ExtensionsServiceTest.ReloadExtensions. (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extensions_service_unittest.cc
diff --git a/chrome/browser/extensions/extensions_service_unittest.cc b/chrome/browser/extensions/extensions_service_unittest.cc
index 90350fa1c52f888124bb4fe30118cb0dc057b0fa..caeb00b1fb282d42b63cca565040f878577a2b0e 100644
--- a/chrome/browser/extensions/extensions_service_unittest.cc
+++ b/chrome/browser/extensions/extensions_service_unittest.cc
@@ -1527,6 +1527,10 @@ TEST_F(ExtensionsServiceTest, ReloadExtensions) {
EXPECT_EQ(1u, service_->extensions()->size());
EXPECT_EQ(0u, service_->disabled_extensions()->size());
+ // Need to clear |loaded_| manually before reloading as the
+ // EnableExtension() call above inserted into it and
+ // UnloadAllExtensions() doesn't send out notifications.
+ loaded_.clear();
service_->ReloadExtensions();
// Extension counts shouldn't change.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698