Issue 2742009: Modify postinstall to avoid x86-specific dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2742009: Modify postinstall to avoid x86-specific dependencies. (Closed)

Created:
10 years, 6 months ago by prigge

Modified:
9 years, 7 months ago

Reviewers:
Bill Richardson

CC:
chromium-os-reviews_chromium.org, cros.approvers_codeaurora.org, chromeboy, robotboy

Base URL:
http://src.chromium.org/git/installer.git

Visibility:
Public.

Description

Modify postinstall to avoid x86-specific dependencies. ARM postinstall is broken otherwise.

Patch Set 2 : Use already defined function to get root device #

Patch Set 3 : Rebase #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	chromeos-postinst	View	1 2	3 chunks	+14 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Richardson

Comments. http://codereview.chromium.org/2742009/diff/1/2 File chromeos-postinst (right): http://codereview.chromium.org/2742009/diff/1/2#newcode17 chromeos-postinst:17: ROOT_DEV=echo "${INSTALL_DEV}" | sed 's/p*[0-9]*//g' Can you source ...

10 years, 6 months ago (2010-06-12 00:29:49 UTC) #2

LGTM