Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2871019: More cleanup of MSVC errors (Closed)

Created:
10 years, 6 months ago by Randall Spangler
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://gitrw.chromium.org/vboot_reference.git
Visibility:
Public.

Description

More cleanup of MSVC errors

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
M firmware/Makefile View 1 chunk +1 line, -0 lines 1 comment Download
M firmware/include/sysincludes.h View 1 chunk +1 line, -1 line 0 comments Download
M firmware/lib/cgptlib/cgptlib_internal.c View 1 chunk +1 line, -1 line 0 comments Download
M firmware/lib/cgptlib/include/gpt.h View 2 chunks +2 lines, -2 lines 0 comments Download
M firmware/lib/cryptolib/rsa.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Randall Spangler
10 years, 6 months ago (2010-06-22 01:20:15 UTC) #1
gauravsh
lgtm http://codereview.chromium.org/2871019/diff/1/3 File firmware/Makefile (right): http://codereview.chromium.org/2871019/diff/1/3#newcode13 firmware/Makefile:13: -I$(STUBDIR)/include \ nit: alpha
10 years, 6 months ago (2010-06-22 01:22:21 UTC) #2
Bill Richardson
10 years, 6 months ago (2010-06-22 01:23:29 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698